Skip to content

Rewriting rpc stuff, again?#1498

Merged
Taiko2k merged 1 commit intoTaiko2k:masterfrom
RSKYS:red/rpc
Mar 27, 2025
Merged

Rewriting rpc stuff, again?#1498
Taiko2k merged 1 commit intoTaiko2k:masterfrom
RSKYS:red/rpc

Conversation

@RSKYS
Copy link
Contributor

@RSKYS RSKYS commented Mar 15, 2025

Another PR for #1350 afterward

@C0rn3j
Copy link
Collaborator

C0rn3j commented Mar 15, 2025

You've managed to change the whitespace in this PR

@RSKYS
Copy link
Contributor Author

RSKYS commented Mar 15, 2025

Is it incorrect? I adjusted them all manually in code with ctrl [], thought this might be better

@C0rn3j
Copy link
Collaborator

C0rn3j commented Mar 15, 2025

Yes, Tauon uses tabs, spaces are not better, they force your preferred indent-width onto others, meanwhile you can set tabs to your preference in your editor.

@RSKYS
Copy link
Contributor Author

RSKYS commented Mar 15, 2025

Huh, cute
Never thought it'd be a thing, I'm sure I see spaces among codes too though time to time; or maybe used to see

Anyway, fixed

@RSKYS RSKYS force-pushed the red/rpc branch 12 times, most recently from 1a7c593 to af2eb8f Compare March 20, 2025 10:57
Signed-off-by: Pouria Rezaei <Pouria.rz@outlook.com>
@RSKYS RSKYS marked this pull request as ready for review March 20, 2025 12:23
@Taiko2k
Copy link
Owner

Taiko2k commented Mar 22, 2025

What in the unholy abomination wh, ok I think we can just set these params to whatever the default is rather than this unpacking judo right? Like

**({"large_text": album} if album and not pctl.playing_state == 3 else {}),

to

large_text = album if album and not pctl.playing_state == 3 else None,

though at some point it would be better to just be verbose and set these explicitly before the function call. And preferably with comments as to reasoning

state = None
# If it is a radio station playing then we set state to album because yada yada
if pctl.playing_state == 3:
   state = album
   
RPC.update(state=state...

@Taiko2k Taiko2k merged commit d255ef3 into Taiko2k:master Mar 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants