-
Notifications
You must be signed in to change notification settings - Fork 2
Stemmer #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding croatian stemmer + basic unit test
mttk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, this is pretty simple for a stemmer. IMO we can also export the stopwords to a file (since the rules as well as the trasnforms are in a file), translate and comment everything and it's ok.
requirements.txt
Outdated
| @@ -1,26 +1,58 @@ | |||
| atomicwrites==1.2.1 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are all of the requirements actually required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, I've trimmed down the list (roughly manually) and found that https://medium.com/@tomagee/pip-freeze-requirements-txt-considered-harmful-f0bce66cf895
I'll put the link in the README.md.
… add tests to achieve 100% test coverage
|
Hope to have taken into account your comments. I rewrote the most of the stemmer and added tests to familiarize myself with it. The requirements file should also be cleaner, thanks for all the useful suggestions. |
Added code comments around stemmer for future reference.
Have lemmatizer locally, but need to figure out how to handle resource files (in general in this project).
Also added markdown notes on project guidelines about coding standard.
Output of tests: