Skip to content

Backport cancellation deadlock fix #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TalAloni merged 1 commit into from
Dec 7, 2023
Merged

Backport cancellation deadlock fix #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions StandardSocketsHttpHandler/Net/Http/SocketsHttpHandler/HttpConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,16 +198,6 @@ private Task<int> ConsumeReadAheadTask()
return null;
}

public bool IsNewConnection
{
get
{
// This is only valid when we are not actually processing a request.
Debug.Assert(_currentRequest == null);
return (_readAheadTask == null);
}
}

public bool CanRetry
{
get
Expand Down Expand Up @@ -1494,15 +1484,15 @@ private async Task CopyToExactLengthAsync(Stream destination, ulong length, Canc
}
}

public void Acquire()
internal void Acquire()
{
Debug.Assert(_currentRequest == null);
Debug.Assert(!_inUse);

_inUse = true;
}

public void Release()
internal void Release()
{
Debug.Assert(_inUse);

Expand Down
Loading