Skip to content

Resolving issue #3; override for GetRequestParametersAsync not requiring routeValues being supplied #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TaleLearnCode merged 1 commit into from
Apr 29, 2021
Merged

Resolving issue #3; override for GetRequestParametersAsync not requiring routeValues being supplied #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 25 additions & 4 deletions src/HttpRequestData.Extensions/HttpRequestData.Extensions/HttpRequestDataExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ public static async Task<HttpResponseData> CreateResponseAsync(
/// </summary>
/// <param name="httpRequestData">The <see cref="HttpRequestData"/> for this response.</param>
/// <returns>A <see cref="HttpResponseData"/> with a status of Internal Server Error (500).</returns>
public static HttpResponseData CreateErrorResponseAsync(this HttpRequestData httpRequestData)
public static HttpResponseData CreateErrorResponse(
this HttpRequestData httpRequestData)
{
return httpRequestData.CreateResponse(HttpStatusCode.InternalServerError);
}
Expand All @@ -90,7 +91,9 @@ public static HttpResponseData CreateErrorResponseAsync(this HttpRequestData htt
/// <param name="httpRequestData">The <see cref="HttpRequestData"/> for this response.</param>
/// <param name="exception">The <see cref="Exception"/> causing the Internal Server Error to be returned.</param>
/// <returns>A <see cref="HttpResponseData"/> with a status of Internal Server Error (500) and a response body with the message from <paramref name="exception"/>.</returns>
public static HttpResponseData CreateErrorResponseAsync(this HttpRequestData httpRequestData, Exception exception)
public static HttpResponseData CreateErrorResponse(
this HttpRequestData httpRequestData,
Exception exception)
{
if (exception == default) throw new ArgumentNullException(nameof(exception));
HttpResponseData response = httpRequestData.CreateResponse(HttpStatusCode.InternalServerError);
Expand All @@ -105,7 +108,8 @@ public static HttpResponseData CreateErrorResponseAsync(this HttpRequestData htt
/// <param name="httpRequestData">The <see cref="HttpRequestData"/> to be interrogated for the request object.</param>
/// <returns>A <typeparamref name="T"/> representing the request object from the request.</returns>
/// <exception cref="HttpRequestDataException">Thrown if there is an error reading the request object from the request.</exception>
public static Task<T> GetRequestParameters<T>(this HttpRequestData httpRequestData) where T : new()
public static Task<T> GetRequestParametersAsync<T>(
this HttpRequestData httpRequestData) where T : new()
{
return GetRequestParametersAsync<T>(httpRequestData, new Dictionary<string, string>(), new JsonSerializerOptions());
}
Expand All @@ -118,11 +122,28 @@ public static HttpResponseData CreateErrorResponseAsync(this HttpRequestData htt
/// <param name="routeValues">Any route values supplied to the Azure Function.</param>
/// <returns>A <typeparamref name="T"/> representing the request object from the request.</returns>
/// <exception cref="HttpRequestDataException">Thrown if there is an error reading the request object from the request.</exception>
public static Task<T> GetRequestParameters<T>(this HttpRequestData httpRequestData, Dictionary<string, string> routeValues) where T : new()
public static Task<T> GetRequestParametersAsync<T>(
this HttpRequestData httpRequestData,
Dictionary<string, string> routeValues) where T : new()
{
return GetRequestParametersAsync<T>(httpRequestData, routeValues, new JsonSerializerOptions());
}

/// <summary>
/// Get a request object from the provide <see cref="HttpRequestData"/>.
/// </summary>
/// <typeparam name="T">The type of the request object to be returned.</typeparam>
/// <param name="httpRequestData">The <see cref="HttpRequestData"/> to be interrogated for the request object.</param>
/// <param name="jsonSerializerOptions">The serializer options for formatting the request body.</param>
/// <returns>A <typeparamref name="T"/> representing the request object from the request.</returns>
/// <exception cref="HttpRequestDataException">Thrown if there is an error reading the request object from the request.</exception>
public static Task<T> GetRequestParametersAsync<T>(
this HttpRequestData httpRequestData,
JsonSerializerOptions jsonSerializerOptions) where T : new()
{
return GetRequestParametersAsync<T>(httpRequestData, default, jsonSerializerOptions);
}

/// <summary>
/// Get a request object from the provide <see cref="HttpRequestData"/>.
/// </summary>
Expand Down