fix(QTDI-1963): fix windows path for rootRepo #1101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes Windows path handling for the rootRepo variable by replacing manual URL string manipulation with proper URI-to-Path conversion. The change addresses path parsing issues on Windows systems where the previous approach of manually removing "file:" prefix could fail.
- Replace manual string manipulation with
Path.of(nested.toURI())for proper cross-platform URL-to-path conversion - Add proper exception handling for
URISyntaxExceptionwith informative logging - Remove unused
Pathsimport and add requiredURISyntaxExceptionimport
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| try { | ||
| rootRepo = Path.of(nested.toURI()); | ||
| } catch (URISyntaxException e) { | ||
| info("Cannot convert MAVEN-INF/repository url to path: " + e.getMessage()); |
There was a problem hiding this comment.
The error message should be more descriptive and include the actual URL that failed to convert for better debugging. Consider: 'Cannot convert MAVEN-INF/repository URL to path: ' + nested + ', error: ' + e.getMessage()
Suggested change
| info("Cannot convert MAVEN-INF/repository url to path: " + e.getMessage()); | |
| info("Cannot convert MAVEN-INF/repository URL to path: " + nested + ", error: " + e.getMessage()); |
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
ypiel-talend
added a commit
that referenced
this pull request
Nov 4, 2025
This reverts commit 674c399.
ypiel-talend
added a commit
that referenced
this pull request
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://qlik-dev.atlassian.net/browse/QTDI-1963