feat(cmf): allow bootstrap without settings#2110
Merged
jsomsanith-tlnd merged 3 commits intomasterfrom Apr 1, 2019
Merged
Conversation
Collaborator
nicomaligne
approved these changes
Mar 22, 2019
frassinier
approved these changes
Mar 22, 2019
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the problem this PR is trying to solve?
Settings has been the heart of cmf since the beginning.
But we should allow to write app without injection everywhere.
What is the chosen solution to this problem?
cmf.bootstrap() doesn't fetch and dispatch settings if not settingsURL is provided
Please check if the PR fulfills these requirements
[x] This PR introduces a breaking change
cmf.bootstrapdoesn't have a default settingsURL value anymore. Without settingsURL, no settings will be fetched.To set back the previous behavior, you just need to pass the settingsURL