feat(faceted-search): replace faceted mode toggle by design system switch component by AdelineMrtn · Pull Request #3846 · Talend/ui

AdelineMrtn · 2022-04-06T10:04:31Z

What is the problem this PR is trying to solve?

Added a new switch component in order to improve the UX of the current basic/advanced faceted.
The goal is to have a better readability and understanding thanks to this new switch component.

What is the chosen solution to this problem?

Import "@talend/design-system" in order to use the new toggle form component from design system library.
Adapt the props of this new <Form.Switch/> components.

Please check if the PR fulfills these requirements

The PR have used yarn changeset to a request a release from the CI if wanted.
The PR commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features) And non reg done before need review
Docs have been added / updated (for bug fixes / features)
Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[x] This PR introduces a breaking change

…rom design system

github-actions · 2022-04-06T13:13:40Z

Size Change: +921 B (0%)

Total Size: 14.8 MB

Filename	Size	Change
`./packages/faceted-search/dist/TalendReactFacetedSearch.js`	371 kB	+596 B (0%)
`./packages/faceted-search/dist/TalendReactFacetedSearch.js.dependencies.json`	1.29 kB	+182 B (+16%)	⚠️
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js.dependencies.json`	1.32 kB	+186 B (+16%)	⚠️

ℹ️ View Unchanged

Filename	Size	Change
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js`	35.6 kB	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json`	538 B	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js`	6.81 kB	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json`	557 B	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.js`	52.6 kB	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.js.dependencies.json`	1.07 kB	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js`	11.5 kB	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js.dependencies.json`	1.11 kB	0 B
`./packages/cmf/dist/TalendReactCmf.js`	548 kB	0 B
`./packages/cmf/dist/TalendReactCmf.js.dependencies.json`	1.25 kB	0 B
`./packages/cmf/dist/TalendReactCmf.min.js`	112 kB	0 B
`./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json`	1.29 kB	0 B
`./packages/components/dist/TalendReactComponents.css`	181 kB	0 B
`./packages/components/dist/TalendReactComponents.js`	3.19 MB	0 B
`./packages/components/dist/TalendReactComponents.js.dependencies.json`	2.91 kB	0 B
`./packages/components/dist/TalendReactComponents.min.js`	712 kB	0 B
`./packages/components/dist/TalendReactComponents.min.js.dependencies.json`	2.98 kB	0 B
`./packages/containers/dist/TalendReactContainers.css`	1.73 kB	0 B
`./packages/containers/dist/TalendReactContainers.js`	442 kB	0 B
`./packages/containers/dist/TalendReactContainers.js.dependencies.json`	1.41 kB	0 B
`./packages/containers/dist/TalendReactContainers.min.js`	95.3 kB	0 B
`./packages/containers/dist/TalendReactContainers.min.js.dependencies.json`	1.45 kB	0 B
`./packages/datagrid/dist/TalendReactDatagrid.css`	66 kB	0 B
`./packages/datagrid/dist/TalendReactDatagrid.js`	118 kB	0 B
`./packages/datagrid/dist/TalendReactDatagrid.js.dependencies.json`	1.34 kB	0 B
`./packages/datagrid/dist/TalendReactDatagrid.min.js`	21.9 kB	0 B
`./packages/datagrid/dist/TalendReactDatagrid.min.js.dependencies.json`	1.38 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.css`	6.94 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.js`	831 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.js.dependencies.json`	853 B	0 B
`./packages/dataviz/dist/TalendReactDataviz.min.js`	572 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.min.js.dependencies.json`	876 B	0 B
`./packages/design-system/dist/TalendDesignSystem.css`	1.17 MB	0 B
`./packages/design-system/dist/TalendDesignSystem.js`	1.13 MB	0 B
`./packages/design-system/dist/TalendDesignSystem.js.dependencies.json`	1.36 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.min.js`	169 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.min.js.dependencies.json`	1.39 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.css`	34.8 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.js`	33 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.js.dependencies.json`	2 B	0 B
`./packages/design-tokens/dist/TalendDesignTokens.min.js`	27.3 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.min.js.dependencies.json`	2 B	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.css`	14.8 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js`	94.5 kB	-43 B (0%)
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js`	57.2 kB	0 B
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js.dependencies.json`	935 B	0 B
`./packages/forms/dist/TalendReactForms.css`	20.7 kB	0 B
`./packages/forms/dist/TalendReactForms.js`	1.34 MB	0 B
`./packages/forms/dist/TalendReactForms.js.dependencies.json`	1.81 kB	0 B
`./packages/forms/dist/TalendReactForms.min.js`	417 kB	0 B
`./packages/forms/dist/TalendReactForms.min.js.dependencies.json`	1.86 kB	0 B
`./packages/http/dist/TalendHttp.js`	26.4 kB	0 B
`./packages/http/dist/TalendHttp.js.dependencies.json`	2 B	0 B
`./packages/http/dist/TalendHttp.min.js`	4.82 kB	0 B
`./packages/http/dist/TalendHttp.min.js.dependencies.json`	2 B	0 B
`./packages/icons/dist/bundle.js`	6.31 kB	0 B
`./packages/icons/dist/info.js`	10.8 kB	0 B
`./packages/icons/dist/react.esm.js`	530 kB	0 B
`./packages/icons/dist/react.js`	570 kB	0 B
`./packages/icons/dist/talend-icons-webfont.css`	16.7 kB	0 B
`./packages/icons/dist/talendicons.css`	334 B	0 B
`./packages/icons/dist/TalendIcons.js`	626 kB	0 B
`./packages/icons/dist/TalendIcons.js.dependencies.json`	128 B	0 B
`./packages/icons/dist/TalendIcons.min.js`	554 kB	0 B
`./packages/icons/dist/TalendIcons.min.js.dependencies.json`	131 B	0 B
`./packages/jsfc/dist/index.js`	92.6 kB	0 B
`./packages/jsfc/dist/index.js.dependencies.json`	2 B	0 B
`./packages/router-bridge/dist/TalendRouterBridge.js`	161 kB	0 B
`./packages/router-bridge/dist/TalendRouterBridge.js.dependencies.json`	981 B	0 B
`./packages/router-bridge/dist/TalendRouterBridge.min.js`	24.5 kB	0 B
`./packages/router-bridge/dist/TalendRouterBridge.min.js.dependencies.json`	1.01 kB	0 B
`./packages/sagas/dist/TalendReactSagas.js`	12.1 kB	0 B
`./packages/sagas/dist/TalendReactSagas.js.dependencies.json`	348 B	0 B
`./packages/sagas/dist/TalendReactSagas.min.js`	2.13 kB	0 B
`./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json`	360 B	0 B
`./packages/stepper/dist/TalendReactStepper.js`	26.3 kB	0 B
`./packages/stepper/dist/TalendReactStepper.js.dependencies.json`	833 B	0 B
`./packages/stepper/dist/TalendReactStepper.min.js`	4.86 kB	0 B
`./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json`	855 B	0 B
`./packages/theme/dist/bootstrap.css`	149 kB	0 B
`./packages/theme/dist/bootstrap.js`	4.33 kB	0 B
`./packages/theme/dist/bootstrap.js.dependencies.json`	3 B	0 B

_{compressed-size-action}

…oolbar.component.js Co-authored-by: Fabien <frassinier@talend.com>

…aceted_toggle_by_switch' of github.com:Talend/ui into amartineau/feat/faceted-search/replace_basic_advanced_faceted_toggle_by_switch

…ic_advanced_faceted_toggle_by_switch

Nigui force-pushed the amartineau/feat/faceted-search/replace_basic_advanced_faceted_toggle_by_switch branch from 8657a10 to 862613c Compare April 6, 2022 10:10

Nigui had a problem deploying to pull_request_unsafe April 6, 2022 10:10 Failure

Nigui temporarily deployed to pull_request_unsafe April 6, 2022 10:10 Inactive

Nigui had a problem deploying to pull_request_unsafe April 6, 2022 10:10 Failure

Nigui force-pushed the amartineau/feat/faceted-search/replace_basic_advanced_faceted_toggle_by_switch branch from 862613c to 6fdb9be Compare April 6, 2022 10:14

Nigui had a problem deploying to pull_request_unsafe April 6, 2022 10:14 Failure

Nigui temporarily deployed to pull_request_unsafe April 6, 2022 10:14 Inactive

Nigui had a problem deploying to pull_request_unsafe April 6, 2022 10:14 Failure

Nigui had a problem deploying to pull_request_unsafe April 6, 2022 12:24 Failure

Nigui force-pushed the amartineau/feat/faceted-search/replace_basic_advanced_faceted_toggle_by_switch branch from 6fdb9be to 54dcdf2 Compare April 6, 2022 12:34

Nigui had a problem deploying to pull_request_unsafe April 6, 2022 12:34 Failure

Nigui temporarily deployed to pull_request_unsafe April 6, 2022 12:34 Inactive

Nigui had a problem deploying to pull_request_unsafe April 6, 2022 12:34 Failure

Nigui had a problem deploying to pull_request_unsafe April 6, 2022 13:00 Failure

Nigui had a problem deploying to pull_request_unsafe April 6, 2022 13:01 Failure

feat(faceted-search) replace preview switch by new switch component f…

fc4a6cb

…rom design system

Nigui force-pushed the amartineau/feat/faceted-search/replace_basic_advanced_faceted_toggle_by_switch branch from 54dcdf2 to fc4a6cb Compare April 6, 2022 13:02

Nigui temporarily deployed to pull_request_unsafe April 6, 2022 13:02 Inactive

Kporal changed the title ~~feat(faceted-search) replace preview switch by new switch component f…~~ feat(faceted-search): replace preview switch by new switch component from design system Apr 6, 2022

Kporal changed the title ~~feat(faceted-search): replace preview switch by new switch component from design system~~ feat(faceted-search): replace faceted mode toggle by design system switch component Apr 6, 2022

AdelineMrtn temporarily deployed to pull_request_unsafe April 6, 2022 13:53 Inactive

AdelineMrtn added need review and removed enhancement labels Apr 6, 2022

AdelineMrtn marked this pull request as ready for review April 6, 2022 15:05

frassinier reviewed Apr 6, 2022

View reviewed changes

Comment thread packages/faceted-search/src/components/FacetedToolbar/FacetedToolbar.component.js Outdated

Update packages/faceted-search/src/components/FacetedToolbar/FacetedT…

ce0aaa8

…oolbar.component.js Co-authored-by: Fabien <frassinier@talend.com>

AdelineMrtn temporarily deployed to pull_request_unsafe April 6, 2022 15:19 Inactive

ncomont suggested changes Apr 6, 2022

View reviewed changes

Comment thread packages/faceted-search/src/components/FacetedToolbar/FacetedToolbar.component.js Outdated

AdelineMrtn added 2 commits April 7, 2022 11:22

chore:refactoring Form.Switch component

8341b8f

Merge branch 'amartineau/feat/faceted-search/replace_basic_advanced_f…

84d5061

…aceted_toggle_by_switch' of github.com:Talend/ui into amartineau/feat/faceted-search/replace_basic_advanced_faceted_toggle_by_switch

AdelineMrtn temporarily deployed to pull_request_unsafe April 7, 2022 09:24 Inactive

ncomont approved these changes Apr 7, 2022

View reviewed changes

Merge branch 'master' into amartineau/feat/faceted-search/replace_bas…

19eb44b

…ic_advanced_faceted_toggle_by_switch

ncomont temporarily deployed to pull_request_unsafe April 7, 2022 10:27 Inactive

ncomont temporarily deployed to pull_request_unsafe April 7, 2022 10:28 Inactive

Nigui approved these changes Apr 7, 2022

View reviewed changes

AdelineMrtn merged commit 1c20a3b into master Apr 7, 2022

AdelineMrtn deleted the amartineau/feat/faceted-search/replace_basic_advanced_faceted_toggle_by_switch branch April 7, 2022 12:44

AdelineMrtn temporarily deployed to pull_request_unsafe April 7, 2022 12:44 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(faceted-search): replace faceted mode toggle by design system switch component#3846

feat(faceted-search): replace faceted mode toggle by design system switch component#3846
AdelineMrtn merged 7 commits intomasterfrom
amartineau/feat/faceted-search/replace_basic_advanced_faceted_toggle_by_switch

AdelineMrtn commented Apr 6, 2022 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 6, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

AdelineMrtn commented Apr 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

AdelineMrtn commented Apr 6, 2022 •

edited

Loading

github-actions Bot commented Apr 6, 2022 •

edited

Loading