fix: minimatch remediation: upgrade glob v8→v11#5735
Merged
jmfrancois merged 4 commits intomasterfrom Mar 6, 2026
Merged
Conversation
|
…k v7 addons from forms Co-authored-by: jmfrancois <19857479+jmfrancois@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove unused dependencies to eliminate minimatch
minimatch remediation: upgrade glob v8→v11 in scripts-utils, remove stale storybook v7 addons from forms
Mar 5, 2026
Contributor
|
Storybook for this PR deployed on this github page |
Contributor
jmfrancois
approved these changes
Mar 6, 2026
mhuchet
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the broader
minimatch < 9.0.7remediation. Addresses two dependency chains that pulled in vulnerable minimatch versions.Changes
tools/scripts-utils— glob v8 → v11globfrom^8.1.0to^11.0.0globMatch()to use glob v11's native async API instead of the removed callback formEliminates:
minimatch@5.1.6viaglob@8 → minimatch@5packages/forms— remove unused storybook v7 addon packages@storybook/addon-actions@^7.6.21and@storybook/addon-controls@^7.6.21fromdevDependenciesstorybookcore in v10 (no separate packages exist)Eliminates:
minimatch@9.0.5via@storybook/core-common → glob → minimatchAlready done (no changes needed)
codecovfromfork/dynamic-cdn-webpack-plugin) ✓browser-syncfrompackages/design-system) ✓eslint-plugin-mdxv2→v3) ✓ — already at^3.7.0Original prompt
This section details on the original issue you should resolve
<issue_title>Minimatch < 9.0.7 — Remediation Plan</issue_title>
<issue_description>
Security vulnerability in
minimatchversions below 9.0.7. Each step = one dedicated PR.PR 1 — Remove
codecovfrom fork/dynamic-cdn-webpack-plugin DONEfork/dynamic-cdn-webpack-plugin/package.jsoncodecov@^3.8.3fromdevDependenciescodecovnpm package is deprecated (Codecov migrated to GitHub Actions). No usage in code or scripts.codecov → ignore-walk → minimatch)yarn why minimatch—codecovchain gonePR 2 — Remove
browser-syncfrom packages/design-system DONEpackages/design-system/package.jsonbrowser-sync@^3.0.4andbrowser-sync-webpack-plugin@^2.4.0fromdevDependenciesbrowser-sync → resp-modifier → minimatch)yarn why minimatch—browser-syncchain gonePR 3 — Upgrade
globin tools/scripts-utils (v8 → v11)File:
tools/scripts-utils/package.json— updateglobfrom^8.1.0to^11.0.0Code change:
tools/scripts-utils/src/glob.js— rewriteglobMatch()from callback API to glob v11 native async API:Eliminates: minimatch@5.1.6 (via
glob@8 → minimatch@5)Effort: low — single function, ~5 lines
Verify:
yarn workspace @talend/scripts-utils testPR 4 — Upgrade Storybook deps in packages/forms (v7 → v10)
packages/forms/package.json@storybook/addon-actionsand@storybook/addon-controlsfrom^7.6.21to^10.2.1(aligns with rest of repo already on Storybook 10.2)@storybook/core-common → glob → minimatch)yarn workspace @talend/react-forms build-storybookPR 5 — Upgrade
eslint-plugin-mdxin tools/scripts-config-eslint (v2 → v3)tools/scripts-config-eslint/package.json— updateeslint-plugin-mdxfrom^2.3.4to^3.x"plugin:mdx/recommended"extends syntax still supportedeslint-mdx → unified-engine → glob) + minimatch@9.0.5 (viaload-plugin → @npmcli/config → @npmcli/map-workspaces → glob)PR 6 — Replace or upgrade
fantasticonin packages/iconspackages/icons/package.json—fantasticon@^3.0.0(devDependency)npx fantasticoninpackages/icons/scripts/build-webfont.mjssvgtofont,webfonts-generator, custom script)yarn workspace @talend/icons build— compare generated font filesPR 7 — Replace or upgrade
fork-ts-checker-webpack-pluginin tools/scripts-config-react-webpacktools/scripts-config-react-webpack/package.json—fork-ts-checker-webpack-plugin@^9.1.0webpack.config.jsandwebpack.config.common.js—useTypescript && new ForkTsCheckerWebpackPlugin()ts-checker-rspack-pluginortsc --noEmitscriptBlocked —
babel-jest/test-excludechaintools/babel-plugin-assets-api/package.json—babel-jest@^29.7.0babel-jest → babel-plugin-istanbul → test-exclude@6 → minimatch@3.1.2test-exclude@7usesminimatch@^9butbabel-plugin-istanbul@6pinstest-exclude@^6.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.