Add unit tests for TTS #463
Merged
+70
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Looks good. Thanks. |
Contributor
Author
|
ok nice. |
Collaborator
|
I think it is pretty clear, but I've been working on this for 3(?) years, so I can't be objective about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tts.rsso far has no own tests, and is only indirectly covered from the other files.Here are some basic ones to get started.
cargo testpasses.It took me a few minutes to get that TTS None means plain-text if I understand it correctly? Should we add a comment for this in the enum?
This is not the
None/Nullbuilt into the language itself, but is just an arbitrary name inside of the enum, right? I'm even a bit surprised this is allowedin Rust, iirc Java doesn't allow a class to be named "class" for example.