Skip to content

Conversation

@ways2read
Copy link
Collaborator

Logo image is now loaded from within MathCATPreferences, so MathCATGUI is untouched after it is generated from wxFormBuilder.
Changed the label of the speech rate option, and changed the logo of the braille highlight option.

This was referenced Mar 20, 2022
Copy link
Collaborator

@NSoiffer NSoiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, but I see the line

import wx.xrc

is back. That will generate an error when run in NVDA needs to go away. I could a line or two to the build script to remove it or comment it out. Let me know.

Also, why change from point to github to

<property name="path">C:\Users\Rorme\OneDrive - DAISY Consortium\DAISY\Activities\Software tools\MathCAT\MathCATForPython\NVDA-addon\addon\globalPlugins\MathCAT</property>

Change path for code generation to relative
Comment import wx
Comment import wx.xrc
@ways2read
Copy link
Collaborator Author

The import wx.xrc is generated by the wxFormBuilder tool. I don't see anything I can change to stop it from adding this, so I think a build script may be necessary to comment this or remove it.

@NSoiffer
Copy link
Collaborator

Fixes look good. I'll look into adding a line to the build script to deal with the import (I'll probably use 'sed')

@NSoiffer NSoiffer merged commit 1e8441b into main Mar 21, 2022
@ways2read ways2read deleted the GUI-updates branch March 21, 2022 11:23
@ways2read
Copy link
Collaborator Author

ways2read commented Oct 11, 2022 via email

@NSoiffer
Copy link
Collaborator

NSoiffer commented Oct 12, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants