-
Notifications
You must be signed in to change notification settings - Fork 8
Update GUI with improved labels and load logo image #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good, but I see the line
import wx.xrc
is back. That will generate an error when run in NVDA needs to go away. I could a line or two to the build script to remove it or comment it out. Let me know.
Also, why change from point to github to
<property name="path">C:\Users\Rorme\OneDrive - DAISY Consortium\DAISY\Activities\Software tools\MathCAT\MathCATForPython\NVDA-addon\addon\globalPlugins\MathCAT</property>
Change path for code generation to relative
Comment import wx
Comment import wx.xrc
|
The import wx.xrc is generated by the wxFormBuilder tool. I don't see anything I can change to stop it from adding this, so I think a build script may be necessary to comment this or remove it. |
|
Fixes look good. I'll look into adding a line to the build script to deal with the import (I'll probably use 'sed') |
|
The surplus import statement is a known bug in wxFormBuilder
Error in Python creation code · Issue #171 · wxFormBuilder/wxFormBuilder (github.com)<wxFormBuilder/wxFormBuilder#171>
It was logged nearly 10 years ago, so I think your fix in the build script may be the fastest approach 😉
|
|
Ok. Since it is working, leaving it is faster than fixing it ;-)
I have a request for another item for the dialog: "Say 'cap' for math
speech" followed by a checkbox. The chemistry group feels this is
important. But don't add it quite yet. I just added a checkbox to the
MathCATDemo page (probably will show up Thursday your time) along with an
automatic pitch change for caps so they can test out what pitch change vs
"cap" is like.
Neil
…On Tue, Oct 11, 2022 at 1:53 AM Richard Orme ***@***.***> wrote:
The surplus import statement is a known bug in wxFormBuilder
Error in Python creation code · Issue #171 · wxFormBuilder/wxFormBuilder (
github.com)<wxFormBuilder/wxFormBuilder#171>
It was logged nearly 10 years ago, so I think your fix in the build script
may be the fastest approach 😉
—
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALZM3CQN35I72XFRUCGX23WCUTJZANCNFSM5RF4I73A>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Logo image is now loaded from within MathCATPreferences, so MathCATGUI is untouched after it is generated from wxFormBuilder.
Changed the label of the speech rate option, and changed the logo of the braille highlight option.