Skip to content

Trim identify requests #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tudddorrr merged 1 commit into from
Sep 4, 2025
Merged

Trim identify requests #613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/services/api/player-api.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ async function getRealIdentifier(
}
}

return identifier
return identifier.trim()
}

export async function findAliasFromIdentifyRequest(
Expand All @@ -47,7 +47,7 @@ export async function findAliasFromIdentifyRequest(
const em: EntityManager = req.ctx.em
const aliasStream = streamCursor<PlayerAlias>(async (batchSize, after) => {
return em.repo(PlayerAlias).findByCursor({
service,
service: service.trim(),
identifier: await getRealIdentifier(req, key, service, identifier)
}, {
first: batchSize,
Expand Down
3 changes: 3 additions & 0 deletions src/services/player.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ export default class PlayerService extends Service {
const player = new Player(game)
if (aliases) {
for await (const alias of aliases) {
alias.service = alias.service.trim()
alias.identifier = alias.identifier.trim()

const count = await em.getRepository(PlayerAlias).count({
service: alias.service,
identifier: alias.identifier,
Expand Down