Check memberships in for...of loop

[tudddorrr]

No description provided.

[claude]

PR Review #725

After thorough analysis of the changes, this PR looks good overall. The refactoring from parallel Promise.all() to sequential processing with forked EntityManagers correctly addresses race condition issues when multiple membership checks try to flush simultaneously.

1. Code Quality and Best Practices

No issues found

---

2. Potential Bugs or Issues

No issues found

---

3. Performance Considerations

No issues found - The sequential processing is a necessary tradeoff to ensure EntityManager isolation. While this reduces throughput compared to parallel processing, it prevents the race conditions that occur when multiple flushes attempt to write to the same EntityManager concurrently.

---

4. Security Concerns

No issues found

---

5. Test Coverage

No issues found - This is a utility function called from tested code paths.

---

Overall Assessment: ✅ Ready to merge. The change correctly addresses concurrency issues in the EntityManager usage pattern.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.20%. Comparing base (360c830) to head (5ebcac0).
⚠️ Report is 6 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #725   +/-   ##
========================================
  Coverage    99.20%   99.20%           
========================================
  Files          223      223           
  Lines        16473    16475    +2     
  Branches      1504     1505    +1     
========================================
+ Hits         16342    16344    +2     
  Misses         129      129           
  Partials         2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.