Skip to content

Check memberships in for...of loop #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tudddorrr merged 1 commit into from
Dec 4, 2025
+9 −6
Merged

Check memberships in for...of loop #725

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/lib/queues/game-metrics/flush-metrics-queue-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,15 @@ let redis: Redis
export async function postFlushCheckMemberships(playerIds: string[]) {
const orm = await getMikroORM()
const em = orm.em.fork() as EntityManager
try {
const players = await em.repo(Player).find({ id: { $in: playerIds } })
const promises = players.map((player) => player.checkGroupMemberships(em))
await Promise.all(promises)
} finally {
em.clear()

const players = await em.repo(Player).find({ id: { $in: playerIds } })
for (const player of players) {
const emFork = em.fork()
try {
await player.checkGroupMemberships(emFork)
} finally {
emFork.clear()
}
}
}

Expand Down
Loading