Skip to content

Preserve ignores for coverage#869

Merged
tudddorrr merged 1 commit intodevelopfrom
preserve-ignores
Feb 27, 2026
Merged

Preserve ignores for coverage#869
tudddorrr merged 1 commit intodevelopfrom
preserve-ignores

Conversation

@tudddorrr
Copy link
Collaborator

No description provided.

@claude
Copy link

claude bot commented Feb 27, 2026

This PR looks good overall — the -- @preserve additions are complete and consistent across the codebase.


🔵 Minor

Inconsistent comment format in flush-metrics-queue-handler.ts:79

One comment places @preserve after descriptive text, diverging from the uniform -- @preserve suffix pattern used everywhere else:

// line 79 (this PR)
/* v8 ignore next -- called manually in tests @preserve */

// all other updated comments
/* v8 ignore next -- @preserve */

Functionally identical since esbuild only checks for the presence of @preserve, but for consistency it could either be:

/* v8 ignore next -- @preserve called manually in tests */
// or
/* v8 ignore next -- @preserve */

Unrelated change in package.json

The @types/koa__cors devDependency was reordered alphabetically. This is correct but unrelated to the PR's stated goal — worth a separate commit or PR for clarity, though not a blocker.

@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.99%. Comparing base (3f81307) to head (0dc0fb6).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #869      +/-   ##
===========================================
+ Coverage    96.67%   96.99%   +0.32%     
===========================================
  Files          388      388              
  Lines         6157     6132      -25     
  Branches       797      784      -13     
===========================================
- Hits          5952     5948       -4     
+ Misses         107       95      -12     
+ Partials        98       89       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tudddorrr tudddorrr merged commit 7b89393 into develop Feb 27, 2026
10 checks passed
@tudddorrr tudddorrr deleted the preserve-ignores branch February 27, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant