Longer last attempt for Steamworks, return better error code#870
Longer last attempt for Steamworks, return better error code#870
Conversation
|
This PR is clean overall — the 503 fix and longer final-attempt timeout are both sensible improvements. One minor issue and one note below. 🔵 Minor
The steamworks errors only ever set // Before (this PR)
if (err instanceof Error && typeof err.cause === 'number') {
return ctx.throw(err.cause, err.message)
}
// Safer alternative
if (err instanceof Error && (err.cause === 400 || err.cause === 503)) {
return ctx.throw(err.cause as number, err.message)
}Note
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #870 +/- ##
========================================
Coverage 96.99% 97.00%
========================================
Files 388 388
Lines 6132 6137 +5
Branches 784 785 +1
========================================
+ Hits 5948 5953 +5
Misses 95 95
Partials 89 89 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a222907 to
f9751b5
Compare
No description provided.