Conversation
Documentation Review -- PR #63: Prop arrays docsThis PR adds clear, well-structured documentation for prop arrays and fills in missing code examples for existing prop functions. The character limit callouts and Clarity and ReadabilityThe "Setting props" code block conflates two separate examples The current block (identical in both Unity and Godot) looks like sequential code but actually contains two independent examples. If read sequentially, Suggested fix -- split into two distinct examples: Talo.current_player.set_prop("level", "5")
Talo.current_player.set_prop("level", "5", false)
Talo.current_player.set_prop("class", "warrior", false)
Talo.current_player.set_prop("xp", "1200")Accuracy and Completeness"Inserting into prop arrays" -- ambiguous behaviour for non-existent arrays
The word "existing" raises an immediate question: what happens if the array has not been created yet? A developer starting from scratch would naturally reach for
Code ExamplesAmbiguous constraint in
It is unclear whether "must not be empty" refers to the raw input or the array after filtering. For example, would Suggested: "Duplicate and empty values are ignored. The resulting array (after filtering) must not be empty." Everything else looks goodStructure, cross-references, GDScript and C# syntax, the |
No description provided.