Add new leaderboard entries chart

[tudddorrr]

No description provided.

[claude]

PR Review: Add new leaderboard entries chart

---

🔴 Code Quality / Potential Bugs

Sorting comparator uses || instead of ?? (line 44)

.sort((keyA, keyB) =>
  (payload.leaderboards[keyB] || payload.change[keyB]) -
  (payload.leaderboards[keyA] || payload.change[keyA])
)

When a leaderboard has 0 new entries, payload.leaderboards[keyB] is falsy, so the sort falls back to payload.change[keyB] — a percentage change value. This mixes counts and percentages in the same comparison, producing incorrect sort order for any zero-entry leaderboard. Use ?? 0 instead:

.sort((keyA, keyB) =>
  (payload.leaderboards[keyB] ?? 0) -
  (payload.leaderboards[keyA] ?? 0)
)

---

🟡 Potential Bugs

Unsafe property access on payload.leaderboards[key] (line 56)

{payload.leaderboards[key].toLocaleString()}

Keys are sourced from Object.keys(payload.leaderboards), so this is safe for the leaderboards map. However, the sort comparator on line 44 falls back to payload.change[keyB] as if a key could exist in change but not in leaderboards. If the backend can return asymmetric records, this will throw at .toLocaleString(). Either document/enforce that both maps always have identical keys, or add a guard: (payload.leaderboards[key] ?? 0).toLocaleString().

---

🔵 Minor

Fragment key uses array index instead of the stable leaderboard name (line 46)

<Fragment key={idx}>

The leaderboard name (key) is already available and is the natural stable identifier here:

<Fragment key={key}>