Use ELK for player save content, restrict node count#474
Conversation
PR Review: Use ELK for player save content, restrict node countPotential BugsStale async layout results (race condition) Both Fix with a cancellation flag: let cancelled = false
void getLayoutedElements(nodeSet, edgeSet, debouncedNodeSizes).then((layoutedNodes) => {
if (\!cancelled) {
setNodes(layoutedNodes)
setEdges(edgeArray)
setCommittedSearch(debouncedSearch)
}
})
return () => { cancelled = true }Minor Issues
The regex const bracketIndex = item.lastIndexOf(' [')
const name = bracketIndex \!== -1 ? item.slice(0, bracketIndex) : itemNon-null assertion on In |
9ad0eee to
3ba526d
Compare
No description provided.