Add player self service delete page

[tudddorrr]

No description provided.

[claude]

PR #485 Review: Add player self service delete page

Overall, this is a well-structured feature with good test coverage and clean component decomposition. A few items worth addressing:

---

Code Quality

Footer.tsx - path check is too broad

The check location.pathname.startsWith('/manage/') hides the footer for any future route under /manage/, not just the self-service delete page. As new self-service routes are added, they will silently lose the footer without an explicit decision being made. A more sustainable approach would be to handle this at the Router level (rendering the footer conditionally based on matched routes), or at minimum check against the specific selfServiceRoutes constants rather than a loose prefix.

---

useGameFromToken.ts - fetcher recreated on every render

The fetcher function is defined inside the hook body and recreated on every render. SWR does not use the fetcher reference as part of its cache key so this does not cause re-fetching, but it is unnecessarily wasteful. Since the fetcher has no closure dependencies, it should be defined at module scope outside the hook.

---

Minor

DeletePlayerLogin / DeletePlayerVerify - isLoading not reset on success

In both components, the catch block calls setLoading(false), but the success path does not. Because the parent transitions the step on success (unmounting these components), there is no visible impact in React 18. However, the asymmetry with the error path is confusing to read. Calling setLoading(false) before invoking the success callback would make the pattern consistent.

---

Security: No issues found.

Potential Bugs: No issues found.

Performance: No issues beyond the fetcher note above.