Add Google Play Games integration settings#490
Conversation
|
PR Review: Add Google Play Games Integration Settings Security - Client secret rendered as plain text In GooglePlayGamesIntegrationDetails.tsx, the OAuth client secret TextInput has no type="password", so the value is visible as the user types. The fix is to include it in inputExtra alongside the register spread. Minor - Index-based button selection in tests Integrations.test.tsx uses positional indexing to click the correct "Enable integration" button (enableButtons[0] for Steamworks, enableButtons[1] for Google Play). If tile order ever changes, the tests will silently test the wrong integration. A more specific selector would make this robust. Overall the integration is well-structured: discriminated union schema, solid test coverage, consistent patterns with Steamworks. The client secret masking is the main thing to address before merge. |
d2cb13e to
67754f9
Compare
67754f9 to
1a20c31
Compare
No description provided.