Skip to content

Add Google Play Games integration settings#490

Merged
tudddorrr merged 1 commit intodevelopfrom
google-play-games-integration
Mar 15, 2026
Merged

Add Google Play Games integration settings#490
tudddorrr merged 1 commit intodevelopfrom
google-play-games-integration

Conversation

@tudddorrr
Copy link
Copy Markdown
Collaborator

No description provided.

@tudddorrr tudddorrr added the enhancement New feature or request label Mar 15, 2026
@claude
Copy link
Copy Markdown

claude Bot commented Mar 15, 2026

PR Review: Add Google Play Games Integration Settings

Security - Client secret rendered as plain text

In GooglePlayGamesIntegrationDetails.tsx, the OAuth client secret TextInput has no type="password", so the value is visible as the user types. The fix is to include it in inputExtra alongside the register spread.

Minor - Index-based button selection in tests

Integrations.test.tsx uses positional indexing to click the correct "Enable integration" button (enableButtons[0] for Steamworks, enableButtons[1] for Google Play). If tile order ever changes, the tests will silently test the wrong integration. A more specific selector would make this robust.


Overall the integration is well-structured: discriminated union schema, solid test coverage, consistent patterns with Steamworks. The client secret masking is the main thing to address before merge.

@tudddorrr tudddorrr force-pushed the google-play-games-integration branch 2 times, most recently from d2cb13e to 67754f9 Compare March 15, 2026 22:25
@tudddorrr tudddorrr force-pushed the google-play-games-integration branch from 67754f9 to 1a20c31 Compare March 15, 2026 22:28
@tudddorrr tudddorrr merged commit 9de2d03 into develop Mar 15, 2026
5 checks passed
@tudddorrr tudddorrr deleted the google-play-games-integration branch March 15, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant