Release 0.46.0

[tudddorrr]

No description provided.

[claude]

🔍 Code Review - Release 0.46.0

---

🏗️ Code Quality & Best Practices

ChannelsAPI.cs:297

• GetMembers method signature change is breaking - return type changed from PlayerAlias[] to ChannelsMembersResponse
• Consider deprecation approach rather than immediate breaking change

EventsAPI.cs:10-11

• Fields changed from private to internal without clear justification
• Could expose internal state unnecessarily

Exception Variable Naming
Multiple files use inconsistent exception variable naming (e vs ex). The codebase should standardize on one approach.

---

🐛 Potential Bugs & Issues

PlayersAPI.cs:128

• DeleteOfflineAlias() silently catches all exceptions in file deletion
• Should distinguish between file not found vs. other I/O errors

LiveConfig.cs:35-43

• GetOfflineConfig() returns null on any exception, masking real issues
• File corruption or permission errors will be silently ignored

ClearIdentity Method (PlayersAPI.cs:167-190)

• Multiple try-catch blocks with only warning logs could leave system in inconsistent state
• No validation that all cleanup operations succeeded

---

⚡ Performance Considerations

Search Implementation

• PlayersSearchResponse lacks pagination controls in the API design
• Could lead to large result sets being returned without proper chunking

File I/O Operations

• Multiple synchronous file operations in LiveConfig and PlayersAPI could block main thread
• Consider async file operations where Unity supports them

---

🔒 Security Concerns

Query Parameter Handling

• GetMembersOptions.ToQueryString() doesn't URL encode parameter values
• Could allow injection if user input is passed directly to propKey/propValue

File Path Hardcoding

• Offline data paths use predictable names (ta.bin, tlc.bin)
• Consider adding randomization or user-specific paths to prevent predictable file locations

---

⚠️ Backwards Compatibility

Breaking API Changes:

• ChannelsAPI.GetMembers() return type change will break existing code
• PlayerGroupsAPI.Get() return type and signature changes
• Both need proper deprecation warnings or version compatibility handling

Event Handler Addition

• New OnIdentityCleared event in PlayersAPI is additive and safe

Internal Field Exposure

• Making EventsAPI fields internal could be relied upon by tests/external code inappropriately

---

🤖 Generated with Claude Code

[claude]

🔍 Code Review: Release 0.46.0

---

🐛 Potential Bugs & Issues

File I/O Error Handling

• LiveConfig.cs:39-44: Writing offline config only logs warnings on failure but continues execution. Consider whether operation should fail gracefully or retry.
• PlayersAPI.cs:152-159: DeleteOfflineAlias() catches all exceptions broadly. Consider more specific exception handling for file access vs. permission issues.

Default Parameter Values

• LiveConfig.cs:24: Using default(T) instead of default - while functional, default is more concise in modern C#.
• ChannelsAPI.cs:304: GetMembers() creates new options object when null, but doesn't validate the channelId parameter.

State Management

• EventsAPI.cs:125-128: ClearQueue() resets all queue states but may cause race conditions if called during an active flush operation.

---

⚡ Performance Considerations

File I/O Operations

• LiveConfig.cs: New offline config persistence adds file I/O operations on every config update. Consider debouncing writes for high-frequency updates.

String Operations

• PlayersAPI.cs:196: query.Trim() and Uri.EscapeDataString() create new string instances. Consider caching for repeated searches.

Collections

• ChannelsAPI.cs:49-54: ToQueryString() creates new Dictionary and uses LINQ operations. For frequently called methods, StringBuilder might be more efficient.

---

🔒 Security Concerns

Data Validation

• PlayersAPI.cs:196: Search query is trimmed and escaped, but no length validation. Extremely long queries could cause issues.
• ChannelsAPI.cs:304: No validation that channelId is positive or valid before making API calls.

File Path Security

• Hard-coded paths like "/ta.bin" and "/tlc.bin" are secure, but ensure no user input can influence these paths in future changes.

---

🔄 Backwards Compatibility

Breaking API Changes

• ChannelsAPI.cs:300-304: GetMembers() now returns ChannelsMembersResponse instead of PlayerAlias[] - this is a breaking change that will require client updates.
• PlayerGroupsAPI.cs:11-16: Get() method now returns PlayerGroupsGetResponse instead of Group - another breaking change.

Method Signature Changes

• GameConfigAPI.cs: Get() method behavior changed to handle offline mode, but signature remains compatible.
• New optional parameters maintain backward compatibility where added.

---

Overall Assessment: The changes add valuable offline functionality and new features, but include significant breaking changes in the API responses. The code quality is generally good with consistent error handling patterns, though some error handling could be more specific.