Skip to content

Add playerId filter to GetEntriesOptions#177

Merged
tudddorrr merged 1 commit intodevelopfrom
player-id-leaderboard-filter
Feb 24, 2026
Merged

Add playerId filter to GetEntriesOptions#177
tudddorrr merged 1 commit intodevelopfrom
player-id-leaderboard-filter

Conversation

@tudddorrr
Copy link
Contributor

No description provided.

@tudddorrr tudddorrr added the enhancement New feature or request label Feb 24, 2026
@claude
Copy link

claude bot commented Feb 24, 2026

PR Review: Add playerId filter to GetEntriesOptions

This is a clean, minimal PR. The changes are well-scoped, the readonly fix is a good catch, and the updated [Obsolete] messages are consistent across all deprecated overloads.


🔵 Minor — Simultaneous aliasId + playerId usage is undefined

GetEntriesOptions now exposes two independent filter fields with no documentation or validation preventing them from being set at the same time:

var options = new GetEntriesOptions
{
    aliasId = someAliasId,
    playerId = somePlayerId  // Both sent to server simultaneously
};

The resulting query string would include both aliasId=...&playerId=..., but the server behaviour in this case is unspecified from the client side. A brief XML doc comment on the class or fields clarifying their relationship (mutually exclusive vs. combinable) would help callers use this correctly.


No other issues found.

@tudddorrr tudddorrr merged commit 701dbe5 into develop Feb 24, 2026
2 checks passed
@tudddorrr tudddorrr deleted the player-id-leaderboard-filter branch February 24, 2026 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant