Conversation
Add prop array support
Ensure test mode only runs in the Unity editor
Add player auth migrate account API
PR Review: Release 0.55.0\n\nThe prop array system and account migration features are well-structured overall. A few items worth addressing:\n\n### Potential Bug\n\nHandleAccountMigrated clears session token but does not persist a new one\n\nClearSession(false) deletes TaloSessionToken from PlayerPrefs, but HandleAccountMigrated never saves a new token. InvokeIdentifiedEvent fires so the player is identified for this session, but on the next app launch CheckForSession() returns false and autoStartSession will not re-identify them.\n\nIf migration is intentionally designed to require re-authentication via the external service on next launch, that should be documented. If a session token is available post-migration, it should be persisted via SaveSession.\n\n### Minor Issues\n\nSetPropArray throws NullReferenceException on null input - values.Where(...) throws an unguarded NRE if null is passed. A null guard at the top is consistent with the existing argument validation in the method.\n\nRemoving DEBUG from test-mode detection - The change from
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.