Skip to content

Bug: release_issue_success removes in-progress label when PR is opened #335

@Trecek

Description

@Trecek

Problem

Both implementation.yaml and remediation.yaml recipes call release_issue on the success path (release_issue_success step) after CI passes and the PR is opened. This removes the in-progress label from the GitHub issue.

This is wrong. The in-progress label should stay on the issue because:

  1. There's an open PR associated with it — someone is still working on it
  2. Removing the label signals to other pipelines/humans that the issue is available for pickup, which it isn't
  3. When the PR merges and closes the issue, it doesn't matter if the label is still there — the issue is closed

Current behavior

Success path: ci_watchrelease_issue_success (calls release_issue tool) → confirm_cleanup

The release_issue_success step in both recipes removes the in-progress label after a PR is opened and CI passes.

Expected behavior

On the success path (PR opened + CI green), skip the release_issue call. The in-progress label should remain on the issue. Only remove the label on the failure path (release_issue_failure), where no PR was created and the issue genuinely needs to be released for retry.

Affected files

  • src/autoskillit/recipes/implementation.yamlrelease_issue_success step
  • src/autoskillit/recipes/remediation.yamlrelease_issue_success step

Fix

Remove the release_issue_success step in both recipes. Route ci_watch on_success directly to confirm_cleanup instead of through release_issue_success. The release_issue_failure step remains as-is for the failure path.

Requirements

RECIPE

  • REQ-RECIPE-001: The implementation.yaml recipe must NOT call release_issue on the success path when a PR has been opened.
  • REQ-RECIPE-002: The remediation.yaml recipe must NOT call release_issue on the success path when a PR has been opened.
  • REQ-RECIPE-003: The ci_watch step on_success must route directly to confirm_cleanup (bypassing release_issue_success) in both recipes.
  • REQ-RECIPE-004: The release_issue_failure step must remain unchanged — the in-progress label is still released on pipeline failure.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugExisting behavior is brokenin-progressIssue is being actively worked onrecipe:implementationRoute: proceed directly to implementation

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions