-
Notifications
You must be signed in to change notification settings - Fork 0
Description
Problem
Both implementation.yaml and remediation.yaml recipes call release_issue on the success path (release_issue_success step) after CI passes and the PR is opened. This removes the in-progress label from the GitHub issue.
This is wrong. The in-progress label should stay on the issue because:
- There's an open PR associated with it — someone is still working on it
- Removing the label signals to other pipelines/humans that the issue is available for pickup, which it isn't
- When the PR merges and closes the issue, it doesn't matter if the label is still there — the issue is closed
Current behavior
Success path: ci_watch → release_issue_success (calls release_issue tool) → confirm_cleanup
The release_issue_success step in both recipes removes the in-progress label after a PR is opened and CI passes.
Expected behavior
On the success path (PR opened + CI green), skip the release_issue call. The in-progress label should remain on the issue. Only remove the label on the failure path (release_issue_failure), where no PR was created and the issue genuinely needs to be released for retry.
Affected files
src/autoskillit/recipes/implementation.yaml—release_issue_successstepsrc/autoskillit/recipes/remediation.yaml—release_issue_successstep
Fix
Remove the release_issue_success step in both recipes. Route ci_watch on_success directly to confirm_cleanup instead of through release_issue_success. The release_issue_failure step remains as-is for the failure path.
Requirements
RECIPE
- REQ-RECIPE-001: The
implementation.yamlrecipe must NOT callrelease_issueon the success path when a PR has been opened. - REQ-RECIPE-002: The
remediation.yamlrecipe must NOT callrelease_issueon the success path when a PR has been opened. - REQ-RECIPE-003: The
ci_watchstepon_successmust route directly toconfirm_cleanup(bypassingrelease_issue_success) in both recipes. - REQ-RECIPE-004: The
release_issue_failurestep must remain unchanged — the in-progress label is still released on pipeline failure.