Fix load_config() Argument Bug and Consolidate Workspace Assertions#1981
Merged
Trecek merged 2 commits intoMay 6, 2026
Merged
Conversation
Replace three separate test methods each calling load_config() once with a single test_workspace_config_defaults method that calls load_config() once and asserts both worktree_root and runs_root are None. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Trecek
commented
May 6, 2026
Collaborator
Author
Trecek
left a comment
Trecek
left a comment
There was a problem hiding this comment.
AutoSkillit PR Review — Verdict: approved_with_comments
Trecek
commented
May 6, 2026
Collaborator
Author
Trecek
left a comment
Trecek
left a comment
There was a problem hiding this comment.
AutoSkillit review: warning-only findings detected. See inline comments — no blocking changes required.
Trecek
deleted the
fix-load-config-argument-bug-and-consolidate-workspace-asser/1888
branch
Trecek
added a commit
that referenced
this pull request
May 8, 2026
…1981) ## Summary C4-6 (load_config(tmp_path / "settings.toml") wrong arg type) was already resolved by a prior split commit. C4-9 (three separate load_config() calls for one-liner assertions in TestWorkspaceConfig) is the sole remaining change: consolidate three test methods into a single test_workspace_config_defaults method calling load_config(tmp_path) once and asserting all fields together. Drop the hasattr check as redundant. ## Requirements ### C4-6 — load_config() argument bug (ALREADY RESOLVED) Fix `load_config(tmp_path / "settings.toml")` → `load_config(tmp_path)`. Passing a `.toml` file path causes silent fallback to defaults. (Resolved in commit a22cb18.) ### C4-9 — Consolidate TestWorkspaceConfig assertions (REQUIRES ACTION) Consolidate `TestWorkspaceConfig`'s three separate `load_config(tmp_path)` calls into a single `test_workspace_config_defaults` test checking all three fields at once. Drop the `hasattr` check. ## Changed Files ### Modified (●): tests/config/test_config.py Closes #1888 ## Implementation Plan Plan file: `/home/talon/projects/autoskillit-runs/impl-20260505-221514-570647/.autoskillit/temp/make-plan/fix_load_config_argument_bug_and_consolidate_workspace_assertions_plan_2026-05-05_222100.md` 🤖 Generated with [Claude Code](https://claude.com/claude-code) via AutoSkillit <!-- autoskillit:pipeline-signature steps=prepare_pr,run_arch_lenses,compose_pr,annotate_pr_diff,review_pr --> --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
C4-6 (load_config(tmp_path / "settings.toml") wrong arg type) was already resolved by a prior split commit. C4-9 (three separate load_config() calls for one-liner assertions in TestWorkspaceConfig) is the sole remaining change: consolidate three test methods into a single test_workspace_config_defaults method calling load_config(tmp_path) once and asserting all fields together. Drop the hasattr check as redundant.
Requirements
C4-6 — load_config() argument bug (ALREADY RESOLVED)
Fix
load_config(tmp_path / "settings.toml")→load_config(tmp_path). Passing a.tomlfile path causes silent fallback to defaults. (Resolved in commit a22cb18.)C4-9 — Consolidate TestWorkspaceConfig assertions (REQUIRES ACTION)
Consolidate
TestWorkspaceConfig's three separateload_config(tmp_path)calls into a singletest_workspace_config_defaultstest checking all three fields at once. Drop thehasattrcheck.Changed Files
Modified (●):
tests/config/test_config.py
Closes #1888
Implementation Plan
Plan file:
/home/talon/projects/autoskillit-runs/impl-20260505-221514-570647/.autoskillit/temp/make-plan/fix_load_config_argument_bug_and_consolidate_workspace_assertions_plan_2026-05-05_222100.md🤖 Generated with Claude Code via AutoSkillit
Token Usage Summary
Token Efficiency