Fix stale docstrings in workspace and execution tests#1982
Merged
Trecek merged 2 commits intoMay 6, 2026
Conversation
- C5-2: update make-script-skill → write-recipe in test_skills.py (docstring and assertion failure message) - C5-5: update per-symbol test docstrings in test_process_submodules.py to reflect __module__ checks (definition origin) rather than exports Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Trecek
commented
May 6, 2026
Collaborator
Author
Trecek
left a comment
Trecek
left a comment
There was a problem hiding this comment.
AutoSkillit PR Review — Verdict: approved_with_comments
|
|
||
| def test_process_race_exports(): | ||
| """_process_race.py exports race coordination types and functions.""" | ||
| """Race types/functions are defined in _process_race submodule.""" |
Collaborator
Author
There was a problem hiding this comment.
[info] cohesion: Docstring for test_process_race_exports uses the vague category label 'Race types/functions' rather than naming specific exported symbols (e.g., 'RaceAccumulator, RaceSignals'). Other docstrings in the same file enumerate specific symbol names.
Collaborator
Author
There was a problem hiding this comment.
Acknowledged — minor suggestion noted.
Trecek
commented
May 6, 2026
Collaborator
Author
Trecek
left a comment
Trecek
left a comment
There was a problem hiding this comment.
AutoSkillit review: warning-only findings detected. See inline comments — no blocking changes required.
… and test_process_monitor_exports docstrings Replace wildcard glob (_jsonl_* helpers) and Latin abbreviation (_heartbeat et al.) with explicit symbol lists, consistent with the enumeration style used in adjacent test docstrings in the same file.
Trecek
deleted the
fix-stale-docstrings-in-workspace-and-execution-tests/1890
branch
Trecek
added a commit
that referenced
this pull request
May 8, 2026
## Summary Two test files contain stale docstrings and assertion messages that reference old names or misstate what the assertions actually check: - **C5-2** (`tests/workspace/test_skills.py`): `test_bundled_skills_list_matches_filesystem` docstring and failure message still say `make-script-skill` — the skill was renamed to `write-recipe`. - **C5-5** (`tests/execution/test_process_submodules.py`): per-symbol test docstrings say `"exports X"` but the assertions verify `__module__` (definition origin), not `__all__` membership. Each docstring should say `"is defined in X submodule"`. Both fixes are pure string edits in test files. No logic changes, no new fixtures, no isolation concerns. ## Implementation Plan Plan file: `/home/talon/projects/autoskillit-runs/impl-20260505-221516-303979/.autoskillit/temp/make-plan/fix_stale_docstrings_workspace_execution_tests_plan_2026-05-05_000000.md` 🤖 Generated with [Claude Code](https://claude.com/claude-code) via AutoSkillit <!-- autoskillit:pipeline-signature steps=prepare_pr,run_arch_lenses,compose_pr,annotate_pr_diff,review_pr --> --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two test files contain stale docstrings and assertion messages that reference old names
or misstate what the assertions actually check:
tests/workspace/test_skills.py):test_bundled_skills_list_matches_filesystemdocstring and failure message still say
make-script-skill— the skill was renamed towrite-recipe.tests/execution/test_process_submodules.py): per-symbol test docstrings say"exports X"but the assertions verify__module__(definition origin), not__all__membership. Each docstring should say
"is defined in X submodule".Both fixes are pure string edits in test files. No logic changes, no new fixtures, no
isolation concerns.
Implementation Plan
Plan file:
/home/talon/projects/autoskillit-runs/impl-20260505-221516-303979/.autoskillit/temp/make-plan/fix_stale_docstrings_workspace_execution_tests_plan_2026-05-05_000000.md🤖 Generated with Claude Code via AutoSkillit
Token Usage Summary
Token Efficiency