Fix misleading names in session/gating layer#2164
Merged
Trecek merged 3 commits intoMay 7, 2026
Merged
Conversation
Trecek
force-pushed
the
fix-misleading-names-in-session-gating-layer-l3-tool-tags-so/2046
branch
3 times, most recently
from
cd137e3 to
dc1b547
Compare
Renames L3_TOOL_TAGS → FOOD_TRUCK_TOOL_TAGS, SOUS_CHEF_L3_SECTIONS → SOUS_CHEF_FOOD_TRUCK_SECTIONS, moves SESSION_TYPE_COOK/ORDER to cli/session/_constants.py, and adds migration note. Closes #2046
Trecek
force-pushed
the
fix-misleading-names-in-session-gating-layer-l3-tool-tags-so/2046
branch
from
dc1b547 to
dbb9428
Compare
The manifest completeness test requires every non-Python tracked file to be covered by a pattern. The manifest file itself was modified in this branch but lacked an entry mapping it to infra/ tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Trecek
deleted the
fix-misleading-names-in-session-gating-layer-l3-tool-tags-so/2046
branch
Trecek
added a commit
that referenced
this pull request
May 8, 2026
## Summary Rename three misleading identifiers in the session/gating layer to accurately reflect their scope: `AUTOSKILLIT_L3_TOOL_TAGS` becomes `AUTOSKILLIT_FOOD_TRUCK_TOOL_TAGS` (consumed by L2 `SessionType.ORCHESTRATOR` branch, not L3 itself), `SOUS_CHEF_L3_SECTIONS` becomes `SOUS_CHEF_FOOD_TRUCK_SECTIONS` with its `_build_l3_sous_chef_block()` helper renamed to `_build_food_truck_sous_chef_block()`, and `SESSION_TYPE_COOK`/`SESSION_TYPE_ORDER` are separated with an explicit comment clarifying they are CLI session labels, not `SessionType` enum members. ## Requirements ### From Issue #2046 **Acceptance Criteria:** - `AUTOSKILLIT_L3_TOOL_TAGS` renamed to `AUTOSKILLIT_FOOD_TRUCK_TOOL_TAGS` everywhere - `SOUS_CHEF_L3_SECTIONS` renamed to `SOUS_CHEF_FOOD_TRUCK_SECTIONS` - `_build_l3_sous_chef_block()` renamed to `_build_food_truck_sous_chef_block()` - `SESSION_TYPE_COOK`/`ORDER` either moved to CLI package or separated with clear comment - All tests pass - A grep for `L3_TOOL_TAGS` returns zero results - A grep for `L3_SECTIONS` returns zero results (in constant/function names) ## Implementation Plan Plan file: (plan file not present in working directory — see issue body for specification) 🤖 Generated with [Claude Code](https://claude.com/claude-code) via AutoSkillit <!-- autoskillit:pipeline-signature steps=prepare_pr,run_arch_lenses,compose_pr,annotate_pr_diff,review_pr --> ## Token Usage Summary | Step | Model | count | uncached | output | cache_read | peak_ctx | turns | cache_write | time | |------|-------|-------|----------|--------|------------|----------|-------|-------------|------| | plan | claude-sonnet-4-6 | 1 | 88 | 12.8k | 743.7k | 109.1k | 121 | 53.3k | 7m 50s | | verify | claude-opus-4-6 | 1 | 45 | 11.0k | 832.6k | 62.5k | 97 | 49.5k | 4m 45s | | implement* | MiniMax-M2.7-highspeed | 1 | 3.8M | 20.9k | 2.5M | 29.8k | 225 | 54.7k | 8m 4s | | fix | claude-opus-4-6 | 2 | 134 | 14.3k | 2.9M | 59.5k | 120 | 90.0k | 19m 21s | | prepare_pr* | MiniMax-M2.7-highspeed | 1 | 110.4k | 5.3k | 354.1k | 29.7k | 33 | 15.0k | 1m 36s | | compose_pr* | MiniMax-M2.7-highspeed | 1 | 65.7k | 2.1k | 235.1k | 29.7k | 19 | 14.8k | 59s | | **Total** | | | 4.0M | 66.3k | 7.5M | 109.1k | | 277.3k | 42m 37s | \* *Step used a non-Anthropic provider; caching behavior may differ.* ## Token Efficiency | Step | LoC Changed | cache_read/LoC | cache_write/LoC | output/LoC | |------|-------------|----------------|-----------------|------------| | plan | 0 | — | — | — | | verify | 0 | — | — | — | | implement | 185 | 13498.1 | 295.8 | 112.9 | | fix | 14 | 204548.0 | 6429.2 | 1018.9 | | prepare_pr | 0 | — | — | — | | compose_pr | 0 | — | — | — | | **Total** | **199** | 37820.6 | 1393.7 | 333.4 | ## Model Usage Breakdown | Model | steps | uncached | output | cache_read | cache_write | time | |-------|-------|----------|--------|------------|-------------|------| | claude-sonnet-4-6 | 1 | 88 | 12.8k | 743.7k | 53.3k | 7m 50s | | claude-opus-4-6 | 2 | 179 | 25.3k | 3.7M | 139.5k | 24m 6s | | MiniMax-M2.7-highspeed | 3 | 4.0M | 28.3k | 3.1M | 84.5k | 10m 40s | --------- Co-authored-by: Trecek <trecektalon@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename three misleading identifiers in the session/gating layer to accurately reflect their scope:
AUTOSKILLIT_L3_TOOL_TAGSbecomesAUTOSKILLIT_FOOD_TRUCK_TOOL_TAGS(consumed by L2SessionType.ORCHESTRATORbranch, not L3 itself),SOUS_CHEF_L3_SECTIONSbecomesSOUS_CHEF_FOOD_TRUCK_SECTIONSwith its_build_l3_sous_chef_block()helper renamed to_build_food_truck_sous_chef_block(), andSESSION_TYPE_COOK/SESSION_TYPE_ORDERare separated with an explicit comment clarifying they are CLI session labels, notSessionTypeenum members.Requirements
From Issue #2046
Acceptance Criteria:
AUTOSKILLIT_L3_TOOL_TAGSrenamed toAUTOSKILLIT_FOOD_TRUCK_TOOL_TAGSeverywhereSOUS_CHEF_L3_SECTIONSrenamed toSOUS_CHEF_FOOD_TRUCK_SECTIONS_build_l3_sous_chef_block()renamed to_build_food_truck_sous_chef_block()SESSION_TYPE_COOK/ORDEReither moved to CLI package or separated with clear commentL3_TOOL_TAGSreturns zero resultsL3_SECTIONSreturns zero results (in constant/function names)Implementation Plan
Plan file: (plan file not present in working directory — see issue body for specification)
🤖 Generated with Claude Code via AutoSkillit
Token Usage Summary
* Step used a non-Anthropic provider; caching behavior may differ.
Token Efficiency
Model Usage Breakdown