Implementation Plan: Tests for Experiment-Type Registry Expansion#2183
Merged
Trecek merged 2 commits intoMay 7, 2026
Merged
Conversation
…silent-type false-case coverage - Hoist NEW_TYPES constant to module level to eliminate duplication - Add test_new_type_full_schema_valid: 7-parametrize schema validation test - Expand test_is_silent_type_false_for_standard_types: 3 → 11 cases - Total new parameterized cases: 18 (7 + 11), exceeding ≥9 threshold Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…dcoding 11 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Trecek
deleted the
auto-research-2-4-tests-for-experiment-type-registry-expansi/836
branch
Trecek
added a commit
that referenced
this pull request
May 8, 2026
) ## Summary Extend `tests/recipe/test_experiment_type_registry.py` with a parameterized per-type schema-validation test for each of the 7 new experiment types and expand the `is_silent_type` false-case parametrize to cover all non-silent types. Most acceptance criteria from issue #836 are already satisfied by prior work items (#833, #834, #835); the remaining gaps are (1) a parameterized per-type schema validation test and (2) reaching the ≥9 parameterized cases threshold. ## Requirements Extend `tests/recipe/test_experiment_type_registry.py` and related tests to cover the expanded 12-type registry, the priority-ordering mechanism, the silent-type handler, the cache-invalidation path, user-override schema mismatches, and the new dimension_weight_rationale field. Add integration test coverage for the full classification path. ## Conflict Resolution Decisions The following files had merge conflicts that were automatically resolved. ## Architecture Impact ## Changed Files ### Modified (●): ● tests/recipe/test_experiment_type_registry.py ● src/autoskillit/recipes/contracts/merge-prs.json ● src/autoskillit/recipes/implementation-groups.json ● src/autoskillit/recipes/implementation.json ● src/autoskillit/recipes/merge-prs.json ● src/autoskillit/recipes/remediation.json ● src/autoskillit/recipes/research.json Closes #836 ## Implementation Plan Plan file: `/home/talon/projects/autoskillit-runs/impl-20260507-113945-278449/.autoskillit/temp/make-plan/tests_experiment_type_registry_expansion_plan_2026-05-07_114500.md` 🤖 Generated with [Claude Code](https://claude.com/claude-code) via AutoSkillit <!-- autoskillit:pipeline-signature steps=prepare_pr,run_arch_lenses,compose_pr,annotate_pr_diff,review_pr --> ## Token Usage Summary | Step | Model | count | uncached | output | cache_read | peak_ctx | turns | cache_write | time | |------|-------|-------|----------|--------|------------|----------|-------|-------------|------| | plan | claude-sonnet-4-6 | 1 | 3.0k | 12.0k | 924.0k | 76.5k | 97 | 63.4k | 6m 36s | | verify | claude-opus-4-6 | 1 | 39 | 8.7k | 525.8k | 62.0k | 40 | 48.8k | 3m 28s | | implement* | MiniMax-M2.7-highspeed | 1 | 311.3k | 3.6k | 503.2k | 29.8k | 42 | 16.2k | 5m 17s | | prepare_pr* | MiniMax-M2.7-highspeed | 1 | 71.4k | 3.9k | 205.5k | 29.8k | 17 | 15.1k | 1m 24s | | compose_pr* | MiniMax-M2.7-highspeed | 1 | 45.4k | 1.6k | 205.5k | 29.8k | 14 | 15.0k | 48s | | **Total** | | | 431.2k | 29.9k | 2.4M | 76.5k | | 158.5k | 17m 34s | \* *Step used a non-Anthropic provider; caching behavior may differ.* ## Token Efficiency | Step | LoC Changed | cache_read/LoC | cache_write/LoC | output/LoC | |------|-------------|----------------|-----------------|------------| | plan | 0 | — | — | — | | verify | 0 | — | — | — | | implement | 311 | 1617.9 | 52.0 | 11.7 | | prepare_pr | 0 | — | — | — | | compose_pr | 0 | — | — | — | | **Total** | **311** | 7601.3 | 509.7 | 96.1 | ## Model Usage Breakdown | Model | steps | uncached | output | cache_read | cache_write | time | |-------|-------|----------|--------|------------|-------------|------| | claude-sonnet-4-6 | 1 | 3.0k | 12.0k | 924.0k | 63.4k | 6m 36s | | claude-opus-4-6 | 1 | 39 | 8.7k | 525.8k | 48.8k | 3m 28s | | MiniMax-M2.7-highspeed | 3 | 428.2k | 9.1k | 914.2k | 46.3k | 7m 29s | --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extend
tests/recipe/test_experiment_type_registry.pywith a parameterized per-type schema-validation test for each of the 7 new experiment types and expand theis_silent_typefalse-case parametrize to cover all non-silent types. Most acceptance criteria from issue #836 are already satisfied by prior work items (#833, #834, #835); the remaining gaps are (1) a parameterized per-type schema validation test and (2) reaching the ≥9 parameterized cases threshold.Requirements
Extend
tests/recipe/test_experiment_type_registry.pyand related tests to cover the expanded 12-type registry, the priority-ordering mechanism, the silent-type handler, the cache-invalidation path, user-override schema mismatches, and the new dimension_weight_rationale field. Add integration test coverage for the full classification path.Conflict Resolution Decisions
The following files had merge conflicts that were automatically resolved.
Architecture Impact
Changed Files
Modified (●):
● tests/recipe/test_experiment_type_registry.py
● src/autoskillit/recipes/contracts/merge-prs.json
● src/autoskillit/recipes/implementation-groups.json
● src/autoskillit/recipes/implementation.json
● src/autoskillit/recipes/merge-prs.json
● src/autoskillit/recipes/remediation.json
● src/autoskillit/recipes/research.json
Closes #836
Implementation Plan
Plan file:
/home/talon/projects/autoskillit-runs/impl-20260507-113945-278449/.autoskillit/temp/make-plan/tests_experiment_type_registry_expansion_plan_2026-05-07_114500.md🤖 Generated with Claude Code via AutoSkillit
Token Usage Summary
* Step used a non-Anthropic provider; caching behavior may differ.
Token Efficiency
Model Usage Breakdown