Skip to content

Adopt per-run subdirectory output pattern for validate-audit#2219

Merged
Trecek merged 8 commits into
developfrom
validate-audit-adopt-per-run-subdirectory-output-pattern/1960
May 8, 2026
Merged

Adopt per-run subdirectory output pattern for validate-audit#2219
Trecek merged 8 commits into
developfrom
validate-audit-adopt-per-run-subdirectory-output-pattern/1960

Conversation

@Trecek
Copy link
Copy Markdown
Collaborator

@Trecek Trecek commented May 8, 2026

Summary

Change validate-audit (project-local), validate-test-audit, and the extended validate-audit SKILL.md files from writing flat timestamped files into a shared validate-audit/ directory to creating a per-run timestamped subdirectory (validate-audit-{YYYY-MM-DD_HHMMSS}/) with timestamp-free filenames inside. This matches the established pattern used by validate-team. Update downstream path references in skill_contracts.yaml and all affected tests.

Closes #1960

Implementation Plan

Plan file: /home/talon/projects/autoskillit-runs/impl-20260507-225440-809232/.autoskillit/temp/make-plan/validate-audit_adopt_per-run_subdirectory_output_pattern_plan_2026-05-07_225500.md

🤖 Generated with Claude Code via AutoSkillit

Token Usage Summary

Step Model count uncached output cache_read peak_ctx turns cache_write time
plan claude-opus-4-6 1 79 19.2k 755.8k 79.2k 57 85.7k 7m 20s
verify claude-sonnet-4-6 1 29 15.7k 447.8k 54.6k 77 41.5k 7m 44s
implement* MiniMax-M2.7-highspeed 1 3.8M 20.0k 2.3M 29.8k 178 72.2k 7m 30s
prepare_pr* MiniMax-M2.7-highspeed 1 89.7k 4.2k 208.5k 29.8k 20 42.2k 1m 32s
compose_pr* MiniMax-M2.7-highspeed 1 68.6k 1.8k 172.3k 28.7k 16 41.0k 55s
review_pr claude-sonnet-4-6 3 334 127.7k 1.9M 91.5k 138 223.8k 29m 1s
resolve_review claude-sonnet-4-6 3 2.3k 73.3k 5.5M 92.8k 274 200.8k 36m 37s
Total 3.9M 261.8k 11.2M 92.8k 707.2k 1h 30m

* Step used a non-Anthropic provider; caching behavior may differ.

Token Efficiency

Step LoC Changed cache_read/LoC cache_write/LoC output/LoC
plan 0
verify 0
implement 162 13957.0 446.0 123.2
prepare_pr 0
compose_pr 0
review_pr 0
resolve_review 24 229304.4 8366.3 3053.9
Total 186 60407.9 3802.2 1407.5

Model Usage Breakdown

Model steps uncached output cache_read cache_write time
claude-sonnet-4-6 3 295 38.6k 1.9M 131.6k 20m 35s
claude-opus-4-6 1 79 19.2k 755.8k 85.7k 7m 20s
MiniMax-M2.7-highspeed 3 3.9M 25.9k 2.6M 155.4k 9m 57s

Trecek and others added 8 commits May 7, 2026 23:17
…ills

Change validate-audit (project-local), validate-test-audit, and the extended
validate-audit SKILL.md files from writing flat timestamped files into a
shared validate-audit/ directory to creating per-run timestamped subdirectories
(validate-audit-{YYYY-MM-DD_HHMMSS}/) with timestamp-free filenames inside.

Updates:
- Project-local .claude/skills/validate-audit/SKILL.md: critical constraints,
  mkdir command, all file paths, Output Location section
- skills_extended/validate-test-audit/SKILL.md: same pattern updates
- skills_extended/validate-audit/SKILL.md: fallback path now creates per-run
  dir; timestamp suffixes removed from all filenames
- skill_contracts.yaml: pattern_examples updated for both skills
- Tests: T-VAL-014, T-VTA-008 updated; T1/T2/T5/T6 new tests added

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
… symmetry

The validated_report_path gate token was the only path reference without a
human-readable label prefix in the headless output block. Summary/Manifest/
Tickets/Contested all had label: format; validated_report_path used key=value
only. Restores the Report: line alongside the gate token.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…write instruction

The phrase "(relative to the current working directory)" directly contradicts the
{{AUTOSKILLIT_TEMP}} prefix which expands to an absolute path. Removes the
misleading parenthetical added in 41fd59c.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Both tests used prefix-only match {{AUTOSKILLIT_TEMP}}/validate-audit- which
would pass for paths like validate-audit-legacy/. T-VAL-014 now checks the full
validate-audit-{YYYY-MM-DD_HHMMSS}/ pattern. T-VTA-008 now checks the full
{{AUTOSKILLIT_TEMP}}/validate-audit-{YYYY-MM-DD_HHMMSS}/ pattern, consistent
with T-VTA-027 and matching the path structure in each SKILL.md.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
T-VAL-014 checks the BUNDLED_EXTENDED validate-audit which uses bash date
syntax ($(date ...)) not the {YYYY-MM-DD_HHMMSS} literal — prefix assertion
is correct for that skill. The CWD parenthetical in validate-test-audit is
required by test_file_producing_skills_have_cwd_anchor contract test and
cannot be removed without also updating that contract.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…grouping

T-VAL-026 tests a general extended-validate-audit filename convention
(no timestamp suffix) unrelated to review_decisions. Moving it from
TestValidateAuditReviewDecisions to TestValidateAuditContent where
general content assertions live.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ock and remove slop parenthetical

- Sync extended SKILL.md headless block with project-local: add `Report: {validated_report_path}` label before the machine-readable sentinel lines (C1: Report: was added to project-local by bd31ae2 but not the extended skill)
- Remove `(a newly created per-run directory)` parenthetical from Output Location section (F1: colon already signals list follows; implied by mkdir)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@Trecek Trecek added this pull request to the merge queue May 8, 2026
Merged via the queue into develop with commit 85df5ce May 8, 2026
2 checks passed
@Trecek Trecek deleted the validate-audit-adopt-per-run-subdirectory-output-pattern/1960 branch May 8, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant