Implementation Plan: Dry Walkthrough — Test Command Genericization (Issue #307)

[Trecek]

Summary

The dry-walkthrough skill's Step 4.5 (Historical Regression Check) is already fully implemented in SKILL.md — including the git history scan, GitHub issues cross-reference, gh auth guard, actionable vs. informational classification, and the ### Historical Context section in Step 7. Contract tests for Step 4.5 exist and pass in tests/skills/test_dry_walkthrough_contracts.py.

The remaining work is REQ-GEN-002 from Issue #311 (consolidated here): replace the hardcoded task test-all references in Step 4 of SKILL.md with a config-driven reference to test_check.command, so the skill validates correctly for any project regardless of its test runner.

Architecture Impact

Process Flow Diagram

%%{init: {'flowchart': {'nodeSpacing': 40, 'rankSpacing': 50, 'curve': 'basis'}}}%%
flowchart TB
    %% CLASS DEFINITIONS %%
    classDef terminal fill:#1a237e,stroke:#7986cb,stroke-width:2px,color:#fff;
    classDef stateNode fill:#004d40,stroke:#4db6ac,stroke-width:2px,color:#fff;
    classDef handler fill:#e65100,stroke:#ffb74d,stroke-width:2px,color:#fff;
    classDef phase fill:#6a1b9a,stroke:#ba68c8,stroke-width:2px,color:#fff;
    classDef detector fill:#b71c1c,stroke:#ef5350,stroke-width:2px,color:#fff;
    classDef output fill:#00695c,stroke:#4db6ac,stroke-width:2px,color:#fff;
    classDef newComponent fill:#2e7d32,stroke:#81c784,stroke-width:2px,color:#fff;

    %% TERMINALS %%
    START([START])
    PASS([PASS — Ready to implement])
    REVISED([REVISED — See changes])

    subgraph Load ["Step 1: Load & Detect"]
        direction TB
        LOAD["Load Plan<br/>━━━━━━━━━━<br/>arg path / pasted / temp/ scan"]
        MULTIPART{"Multi-part plan?<br/>━━━━━━━━━━<br/>filename contains _part_?"}
        SCOPE_WARN["Scope Warning<br/>━━━━━━━━━━<br/>Insert boundary block<br/>Restrict to this part only"]
    end

    subgraph Validate ["Steps 2–3: Validate Phases"]
        direction TB
        PHASE_V["Phase Subagents<br/>━━━━━━━━━━<br/>files exist · fns exist<br/>assumptions correct<br/>wiring complete"]
        XPHASE["Cross-Phase Deps<br/>━━━━━━━━━━<br/>Phase ordering · implicit deps<br/>reorder safety"]
    end

    subgraph Rules ["● Step 4: Validate Against Project Rules"]
        direction TB
        RULE_CHK["Rule Checklist<br/>━━━━━━━━━━<br/>No compat code · no hidden fallbacks<br/>no stakeholder sections · arch patterns"]
        READ_CFG["● Read test_check.command<br/>━━━━━━━━━━<br/>.autoskillit/config.yaml<br/>default: task test-check"]
        TEST_CMD{"● Non-config test<br/>command in plan?<br/>━━━━━━━━━━<br/>pytest / python -m pytest<br/>make test etc."}
        WORKTREE{"Hardcoded worktree<br/>setup in plan?<br/>━━━━━━━━━━<br/>uv venv / pip install etc."}
    end

    subgraph History ["Step 4.5: Historical Regression Check"]
        direction TB
        GH_AUTH{"gh auth status<br/>━━━━━━━━━━<br/>GitHub auth available?"}
        GIT_SCAN["Git History Scan<br/>━━━━━━━━━━<br/>git log -100 on PLAN_FILES<br/>fix/revert/remove/replace/delete"]
        GIT_SIG{"Signal strength?<br/>━━━━━━━━━━<br/>Symbol-level match?"}
        GH_ISSUES["GitHub Issues XRef<br/>━━━━━━━━━━<br/>open + closed (last 30d)<br/>keyword cross-reference"]
        GH_MATCH{"Issue type?<br/>━━━━━━━━━━<br/>open vs closed match"}
    end

    subgraph Fix ["Steps 5–6: Fix & Mark"]
        direction TB
        FIX["Fix the Plan<br/>━━━━━━━━━━<br/>Direct edits to plan file<br/>No gap-analysis sections"]
        MARK["Mark Verified<br/>━━━━━━━━━━<br/>Dry-walkthrough verified = TRUE<br/>(first line of plan)"]
    end

    REPORT["● Step 7: Report to Terminal<br/>━━━━━━━━━━<br/>Changes Made · Verified<br/>### Historical Context · Recommendation"]

    %% FLOW %%
    START --> LOAD
    LOAD --> MULTIPART
    MULTIPART -->|"YES"| SCOPE_WARN
    MULTIPART -->|"NO"| PHASE_V
    SCOPE_WARN --> PHASE_V
    PHASE_V --> XPHASE
    XPHASE --> RULE_CHK
    RULE_CHK --> READ_CFG
    READ_CFG --> TEST_CMD
    TEST_CMD -->|"YES — replace"| FIX
    TEST_CMD -->|"NO"| WORKTREE
    WORKTREE -->|"YES — flag & replace"| FIX
    WORKTREE -->|"NO"| GH_AUTH
    GH_AUTH -->|"available"| GIT_SCAN
    GH_AUTH -->|"unavailable"| GIT_SCAN
    GIT_SCAN --> GIT_SIG
    GIT_SIG -->|"strong — actionable"| FIX
    GIT_SIG -->|"weak — informational"| REPORT
    GH_AUTH -->|"available"| GH_ISSUES
    GH_ISSUES --> GH_MATCH
    GH_MATCH -->|"closed issue — actionable"| FIX
    GH_MATCH -->|"open issue — informational"| REPORT
    FIX --> MARK
    MARK --> REPORT
    REPORT -->|"issues found"| REVISED
    REPORT -->|"no issues"| PASS

    %% CLASS ASSIGNMENTS %%
    class START,PASS,REVISED terminal;
    class LOAD,PHASE_V,XPHASE,GIT_SCAN,GH_ISSUES handler;
    class RULE_CHK,READ_CFG phase;
    class MULTIPART,TEST_CMD,WORKTREE,GH_AUTH,GIT_SIG,GH_MATCH stateNode;
    class FIX,MARK detector;
    class SCOPE_WARN output;
    class REPORT output;

Loading

● Modified component | ★ New component

Closes #307

Implementation Plan

Plan file: /home/talon/projects/autoskillit-runs/impl-307-20260310-203646-026624/temp/make-plan/dry_walkthrough_historical_regression_plan_2026-03-10_120000.md

🤖 Generated with Claude Code via AutoSkillit

[Trecek]

AutoSkillit review passed. No blocking issues found. (Self-review — cannot approve own PR)