Conversation
jspaezp
requested changes
Mar 25, 2025
| ) | ||
| return proteins | ||
|
|
||
| def read_diann(proteins_tsv: str) -> pd.DataFrame: |
Contributor
There was a problem hiding this comment.
suggestion: rename to read_diann_pg_mat or something that denotes which file is supported
Member
Author
There was a problem hiding this comment.
I have no objections to this. The reason I did it this way was to be consistent with the current parser function names, which are read_encyclopedia and read_metamorpheus. Do you think those function names should also be updated?
Contributor
There was a problem hiding this comment.
I feel like the difference there is that (as far as I can recall ...) those guys only return one matrix (I might be wrong though)
jspaezp
reviewed
Mar 27, 2025
| ) | ||
|
|
||
| # Check data types | ||
| # (if loading from S3, default types are 'O' |
jspaezp
reviewed
Mar 27, 2025
|
|
||
| # Check data types | ||
| # (if loading from S3, default types are 'O' | ||
| if proteins.index.dtype not in ["O", "category", "str"]: |
Contributor
There was a problem hiding this comment.
why did you go with this instead of trying to cast to a number and fail if it cannot?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.