chore(types): tighten TypeScript safety — strict flags, typed linting, public-API type tests, double-cast ban (#564)#579
Merged
AlemTuzlak merged 20 commits intoMay 20, 2026
Conversation
20 tasks
Contributor
|
Important Review skippedToo many files! This PR contains 204 files, which is 54 over the limit of 150. To get a review, narrow the scope: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (204)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit f839c8a
☁️ Nx Cloud last updated this comment at |
@tanstack/ai
@tanstack/ai-anthropic
@tanstack/ai-client
@tanstack/ai-code-mode
@tanstack/ai-code-mode-skills
@tanstack/ai-devtools-core
@tanstack/ai-elevenlabs
@tanstack/ai-event-client
@tanstack/ai-fal
@tanstack/ai-gemini
@tanstack/ai-grok
@tanstack/ai-groq
@tanstack/ai-isolate-cloudflare
@tanstack/ai-isolate-node
@tanstack/ai-isolate-quickjs
@tanstack/ai-ollama
@tanstack/ai-openai
@tanstack/ai-openrouter
@tanstack/ai-preact
@tanstack/ai-react
@tanstack/ai-react-ui
@tanstack/ai-solid
@tanstack/ai-solid-ui
@tanstack/ai-svelte
@tanstack/ai-utils
@tanstack/ai-vue
@tanstack/ai-vue-ui
@tanstack/openai-base
@tanstack/preact-ai-devtools
@tanstack/react-ai-devtools
@tanstack/solid-ai-devtools
commit: |
…atMessages Lock in the per-model provider-options gating across `chat()` and the ai-client → useChat type flow before tightening the compiler so regressions surface as compile failures rather than runtime drift. Covers issue #564 (Stage 1). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…cessFromIndexSignature, noFallthroughCasesInSwitch Tighten the compiler baseline per issue #564 by flipping three flags that are mechanical to absorb. Fix the surfaced fallout: - Add `override` modifiers to adapter classes whose `kind` / `chatStream` / `summarizeStream` members shadow the base abstractions. - Convert dynamic `obj.foo` reads on `Record<*, *>` / index-signature carriers (provider SDK envelopes, JSON-schema walks, devtools wrappers) to bracket notation. - Replace the `Record<string, any>` parameter on `makeStructuredOutputCompatible` with `JSONSchema`, and introduce `toJsonSchema()` so the Standard-Schema → JSONSchema bridge no longer needs `as` casts to bypass index-signature variance. - Bracket Vue template `$slots.X` lookups so vue-tsc accepts them. `exactOptionalPropertyTypes` and `useDefineForClassFields` from the original five-flag set are deferred — the former is the dominant churn (~250 sites) and warrants its own coordinated PR per the issue's review guidance, and the latter breaks vitest's mock-hoisting transform in adapter tests that construct classes with field initializers. Covers issue #564 (Stage 2). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Add a new \`tanstack/ai/typed\` block scoped to packages/typescript/*/src/** that enables eight typed-linting rules per issue #564: - error: no-floating-promises, no-misused-promises, await-thenable, switch-exhaustiveness-check, consistent-type-exports - warn: no-explicit-any, no-non-null-assertion, prefer-readonly Also inverts ban-ts-comment from the base \`@tanstack/eslint-config\` — \`@ts-ignore\` is now disallowed outright and \`@ts-expect-error\` must carry a description. Fixes the fallout each rule surfaced: - Floating promises: prefix \`sendMessage()\` / \`addToolApprovalResponse()\` fire-and-forget calls in the React/Solid UI shells with \`void\`. These are intentionally async at the client layer but synchronous from a DOM event handler's perspective. - Misused promises: widen \`errorState.reload\` callback type from \`() => void\` to \`() => Promise<void>\` in chat-messages props, since the chat client's \`reload()\` is async. - Exhaustive switches: add \`case undefined:\` co-cases for grok realtime events and elevenlabs codec parsing, enumerate the remaining Anthropic stop_reason variants, add explicit cases for video/document content parts in the openai-base responses adapter, add the missing \`thinking\` color in ai-devtools, and extract \`reason\` to a local variable in IterationCard so the discriminator stays in scope. - consistent-type-exports: switch openai-base \`./tool-choice\` to \`export type *\`. Covers issue #564 (Stage 3). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds `scripts/check-ts-suppressions.mjs` (a one-shot Node walker that
greps every `packages/typescript/<pkg>/src/**.{ts,tsx}` for forbidden
suppressions) plus a `test:no-suppressions` script wired into `test:pr`
and `test:ci`.
`@ts-expect-error` remains allowed — the linked typed-ESLint block
requires a description on it, and the variant self-heals when the
underlying error disappears. `@ts-ignore` silently rots.
Issue #564 baseline is zero matches today; adopt the guard so future
regressions surface in CI rather than during incident triage.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Patch bump across every workspace package touched by the strict-flags / typed-linting / suppression-guard work. Public API surface is unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…rectly in Anthropic adapter Collapses 16 `as unknown as <ProviderTool>` phantom-brand casts across Anthropic, Gemini, and OpenRouter tool factories into a single audited `brandProviderTool<T>()` helper in @tanstack/ai. The helper uses `as T` (not `as unknown as T`) so TS's structural-overlap check still applies — future refactors that break the brand contract surface here instead of at distant call sites. Also refactors the Anthropic text adapter to import `ContentBlockParam`, `ThinkingBlockParam`, and `ToolUseBlockParam` directly from `@anthropic-ai/sdk/resources/messages` and pushes thinking-block construction into a properly-typed builder. Eliminates the `as unknown as AnthropicContentBlock` cast that was hiding a TS narrowing limitation rather than a real type mismatch. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sweeps the unaudited `as unknown as <Type>` double-cast pattern out of
library source across 14 packages, then adds a `no-restricted-syntax`
rule to prevent regression.
Why: `as unknown as T` bypasses TypeScript's structural-overlap check
(the safety net that errors when two types don't sufficiently overlap)
— equivalent to `@ts-ignore` for type assertions. Plain `as T` keeps
the check, so refactors that break a cast's structural premise surface
at the cast site instead of at distant call sites.
Per-package results:
- 13 sites reduced to plain `as T` (ai, ai-client, ai-fal, ai-utils)
- 2 bug fixes where the cast was hiding real wrong behavior:
- ai-gemini: JSON.parse fallback was casting a `string` to
`Record<string, unknown>`. Replaced with `parsedArgs = {}`.
- ai-ollama: unreachable defensive branch was casting `never` to
`Record<string, unknown>`. Replaced with `{}` (matches the
JSON-parse failure fallback in the same function).
- 12 sites gated with `// eslint-disable-next-line no-restricted-syntax
-- <reason>` after `as T` failed the structural-overlap check.
Reasons cluster around: conditional return types (4 framework hook
`useChat`/`createChat`), DOM/TS-lib limitations (`String.fromCharCode
.apply(Uint8Array)`, `Uint8Array.fromBase64` Stage-3 proposal),
discriminated-union construction (OpenRouter `NormalizedStreamEvent`
built field-by-field), and a `RTCErrorEvent` duck-type.
Lint rule scoped to `packages/typescript/*/src/**/*.{ts,tsx}` plus
`src/**/*.{ts,tsx}` to also fire under the 4 packages
(ai, ai-client, ai-svelte, ai-fal) that ship a local
`eslint.config.js` re-exporting root — flat-config evaluates `files`
globs relative to the config-file's directory, so the original glob
silently misses those packages.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Four packages (\`ai\`, \`ai-client\`, \`ai-svelte\`, \`ai-fal\`) shipped a
no-op local \`eslint.config.js\` that re-exported root with empty rules.
Flat-config evaluates \`files\` globs relative to the config-file's
directory, so the root's typed-linting block \`packages/typescript/*/src/**\`
glob silently resolved to nothing in those packages — the strict rules
(no-floating-promises, no-misused-promises, switch-exhaustiveness-check,
consistent-type-exports, ban-ts-comment override) didn't apply there.
Removes the four no-op local configs and fixes the violations that
surfaced:
- ai/src/middlewares/otel.ts:118 — \`switch (type)\` missing
\`case undefined:\`. Added with \`[unknown]\` placeholder; dropped the
now-redundant \`?? 'unknown'\` from the default branch.
- ai/src/activities/summarize/chat-stream-summarize.ts:214 —
\`switch (options.style)\` missing \`undefined\`. Added a case that
mirrors the existing default-prompt text.
- ai/src/activities/chat/index.ts:695 and stream/processor.ts:456 —
switches on AG-UI \`EventType\` where case labels are string literals
(\`'TEXT_MESSAGE_START'\` etc.) but the discriminant is the
\`EventType\` enum. The rule's exhaustiveness analysis treats those as
unrelated types and flags every variant as unmatched even though the
default already handles them. Scoped \`eslint-disable-next-line\`
with reason on each switch.
- ai/src/realtime/index.ts:4 — \`export * from './types'\` →
\`export type * from './types'\` (all exports are types).
- ai-client/src/generation-client.ts:162 and
video-generation-client.ts:188 — \`switch (event.type)\` on
AG-UI \`EventType\`; consumer only handles the generation-lifecycle
subset (\`CUSTOM\`, \`RUN_FINISHED\`, \`RUN_ERROR\`). Rule's
\`considerDefaultExhaustiveForUnions\` defaults to false. Added
\`default: break\` plus \`eslint-disable-next-line\` with reason.
- ai-client/src/realtime-client.ts:171,308,347 — fire-and-forget
promise calls (\`startListening\` kicks off audio capture,
\`destroy\` calls \`disconnect\`, refresh-token timer). Prefixed with
\`void\` to make intent explicit.
- ai-client/src/realtime-client.ts:412 — \`no-misused-promises\` on
an async event handler passed to a \`() => void\` slot. Converted
to a sync arrow with an inner \`void (async () => {...})()\` IIFE;
hoisted \`tool.execute\` to a local const to preserve narrowing
across the IIFE boundary.
- ai-fal/src/utils/client.ts:86 — \`switch (ext)\` on
\`string | undefined\`. Added \`case undefined:\` that falls through
to the existing default \`return 'audio/mpeg'\`.
Doesn't address the warnings (~298 across the four packages, mostly
\`no-explicit-any\` and \`no-non-null-assertion\` — both configured as
warnings in the root). Those are a separate cleanup.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…rors Before this commit, of 9 examples only \`ts-react-media\` had a \`test:types\` script. Most ran \`"test": "exit 0"\` and never had their types checked by CI even though every example ships a \`tsconfig.json\` with strict mode. That gap is now closed. For each example: - \`ts-react-chat\` — added \`tsc --noEmit\`. Fixed 4 ElevenLabs adapter calls passing a generic \`string\` where a literal-union model id was expected (\`as 'eleven_multilingual_v2'\` etc.), renamed 4 unused middleware \`ctx\` params to \`_ctx\`, and tightened the transcription generation route's fetcher input to the \`TranscriptionGenerateInput\` shape from \`@tanstack/ai-client\`. - \`ts-vue-chat\` — added \`vue-tsc -b\` (already used in \`build\`). No source fixes needed. - \`ts-solid-chat\` — added \`tsc --noEmit\`. Excluded the generated \`src/routeTree.gen.ts\` and three orphan files (\`src/lib/stub-adapter.ts\`, \`src/lib/stub-llm.ts\`, \`src/utils/demo.tools.ts\` — the first two reference outdated \`@tanstack/ai\` types; the third imports Vercel's \`ai\` package and is unreferenced). Fixed \`api.chat.ts\` to pass the \`serverTools\` array directly to \`mergeAgentTools\` instead of wrapping it in a \`Record\`. - \`ts-svelte-chat\` — added \`svelte-kit sync && svelte-check\`. Same \`mergeAgentTools\` array fix as solid. Split the per-provider \`chat()\` call into a ternary so each branch resolves to a concrete adapter type (spreading the union erased the generic). - \`vanilla-chat\` — created a \`tsconfig.json\` (didn't exist), scoped to the example's \`src/**/*.js\` + \`vite.config.ts\` with \`allowJs: true\` and \`checkJs: false\` so \`tsc\` doesn't surface unrelated JS drift. Added \`tsc --noEmit\`. - \`ts-group-chat\` — added \`tsc --noEmit\`. Removed a dead \`private webSocket\` field, replaced an old AG-UI \`'content'\` stream-chunk discriminator with \`'TEXT_MESSAGE_CONTENT'\`, and typed a tool handler's \`unknown\` args via a single named alias. - \`ts-react-search\` — added \`tsc --noEmit\`. No source fixes needed (tsconfig already excludes generated files). - \`ts-code-mode-web\` — added \`tsc --noEmit\`. Renamed two unused function params and widened a function's first arg from \`AsyncGenerator<StreamChunk>\` to \`AsyncIterable<StreamChunk>\` to match \`chat()\`'s return type. Same anti-pattern (spread of a per-provider \`chat()\` union erasing the generic) is present in \`ts-react-chat\` but doesn't surface under its current tsconfig — left in place to avoid scope creep. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The script was introduced in 0714eea as a backstop for `@ts-ignore` / `@ts-nocheck` enforcement. Its value-add at the time was that the typed-linting block in `eslint.config.js` (which configures `@typescript-eslint/ban-ts-comment` with `'ts-ignore': false` / `'ts-nocheck': true`) silently didn't apply to four packages — `ai`, `ai-client`, `ai-svelte`, `ai-fal` — because each shipped a no-op local `eslint.config.js` that shifted the `files` glob's resolution context. Without the script, those four packages were under the base config's looser policy (allow `@ts-ignore` with a description). The previous commit (720ffd6) deletes those four local configs, so the strict `ban-ts-comment` policy now applies uniformly. The script and ESLint enforce identical rules against identical scopes, both gated by the same CI step. Keeping both creates divergence risk (regex vs. AST policies that can drift), so consolidate on ESLint. Removes: - `scripts/check-ts-suppressions.mjs` - `test:no-suppressions` script in root `package.json` - The `pnpm run test:no-suppressions && ` prefix on `test:pr` and `test:ci` — `test:eslint` already runs in both and catches the same violations. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Anthropic per-model type-test: switch to `id`-form aliases (`claude-3-5-haiku` / `claude-3-haiku`) after #581 narrowed the factory's accepted model union to `id` values rather than `name`. - Re-add `as unknown as UseChatReturn<TTools, TSchema>` cast on the React `useChat` return — main's new `activeStructuredPart` memo changed the runtime shape, so the conditional return-type seam needs the double-cast (the no-restricted-syntax eslint-disable was already in place). - Bracket-notation fixes for `noPropertyAccessFromIndexSignature` violations newly surfaced in code that landed on main: - `process.env.X` reads in gemini/grok test files - `process.env.NODE_ENV` in ai-devtools/src/index.ts - `e.name` / `e.message` index-sig reads in ai-isolate-cloudflare/src/isolate-driver.ts - `Record<string, unknown>` access in message-updaters / openai-base / elevenlabs tests - Cast schema-converter test results to `any` (`const result: any = ...`) so dot-chains on the returned JSON Schema satisfy the new flag without 50+ bracket rewrites; typed-lint rules don't apply to test files. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
tombeckenham
force-pushed
the
564-tighten-typescript-safety-strict-flags-typed-linting-public-api-type-tests
branch
from
b524794 to
58a9a90
Compare
Flips the fifth strict flag from issue #564's original five-flag set on. With ES2020 target, `useDefineForClassFields` is off by default; turning it on emits real ES2022 class fields (Object.defineProperty) instead of [[Set]]-style assignments — closer to runtime semantics and required to keep TS in sync with downstream consumers that default to true (ES2022+ targets). Surfaced one test breakage in `ai-openrouter/tests/openrouter-adapter.test.ts`: the inline `vi.mock` factory returned a class with a `chat` field initializer, and vitest's mock-hoister mis-rewrote that field reference because `chat` was also a top-level named import on line 2. The class-field semantics under `useDefineForClassFields: true` turned the previously-silent collision into a runtime "Cannot access '__vi_import_0__' before initialization" error. Rewrite the mock as a plain constructor function with `this.chat = ...` assignments. The sibling `openrouter-responses-adapter.test.ts` test uses the same inline-class pattern but doesn't collide (field is named `beta`, no matching import) so it's left as-is. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…react
The typed-ESLint block leaves `no-explicit-any`,
`no-non-null-assertion`, and `prefer-readonly` at `warn` to ratchet
later. Clears the warnings in the two packages explicitly called out
for cleanup; the remaining ~600 warnings in other packages are a
separate sweep.
ai-fal:
- `utils/client.ts:41` — `url.split('?')[0]!.split('#')[0]!` had two
forbidden non-null assertions guarding `noUncheckedIndexedAccess`.
Both `String.split` calls return a non-empty array when the
separator is missing, but TS doesn't know that. Replace with
`?.split('#')[0] ?? url` — falls back to the raw input string if
the optional chain ever produces undefined.
- `utils/client.ts:137` — `view[i]!` inside an indexed `for` loop.
Rewrite as `for (const byte of view)` so the binding is statically
non-undefined.
- `model-meta.ts:26,128` — fallback branches for the
`EndpointTypeMap[TModel]` conditional types used
`Record<string, any>`. Tighten to `Record<string, unknown>` so
consumers get a value type they have to narrow.
- `adapters/video.ts:140` — `catch (error: any)` then `error?.body`,
`error.message`. Narrow the catch binding to `unknown` and
introduce a typed local alias for the SDK error shape we read.
ai-preact:
- `addToolResult.output: any` → `output: unknown` in both `types.ts`
and `use-chat.ts`. The framework genuinely doesn't know the result
shape — `unknown` forces callers to narrow rather than silently
accepting anything assignable to `any`.
The `<TTools extends ReadonlyArray<AnyClientTool> = any>` defaults on
the hook generics are deliberately kept — that pattern is shared by
ai-react, ai-solid, ai-svelte, ai-vue, and ai-preact. Changing the
default in one framework only would diverge the surface, and changing
it everywhere is its own refactor.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Flips the final flag from issue #564's original five-flag set on, and fixes the ~300 errors it surfaces across 26 packages. EOPT distinguishes `field?: T` (the property may be absent) from `field?: T | undefined` (may be absent OR explicitly undefined), so spreading an object whose source field is `T | undefined` into a target declared `field?: T` is now a type error. ## Fix patterns Two patterns covered nearly every site. The choice between them is about semantic intent, not convenience. **Widen the target** (`field?: T` → `field?: T | undefined`): used when the field is locally owned and the carry-through-undefined semantics are correct. Most internal interfaces fall here — `BaseEventContext`-style shared-context types, middleware context shapes, devtools store interfaces, eval-local row types, etc. **Conditional spread** (`{ ...(v !== undefined && { field: v }) }`): used when the target is owned by another package (vendor SDK, AG-UI event shapes, framework integration options imported from `@tanstack/ai-client`, etc.) and absence-on-the-wire matters. Provider adapters (OpenAI, Anthropic, Gemini, Ollama, Grok, fal, ElevenLabs, OpenRouter, Groq) all use this for vendor request shapes; framework hooks (ai-react, ai-solid, ai-vue, ai-svelte, ai-preact) use it for `ChatClientOptions`/`GenerationClientOptions` pass-throughs. ## Things deliberately NOT widened - `Tool.inputSchema` / `Tool.outputSchema` and the same fields on `ClientTool`. These participate in `InferToolInput` / `InferToolOutput` via `infer T extends StandardJSONSchemaV1<…>`. Widening to `T | undefined` makes the inference distribute over `undefined` and collapses inferred input/output types to `unknown`, breaking the `chat()` / `useChat()` type-inference contract that the public type-tests in `ai-client/tests/` lock down. Comment added at the declaration to flag this. - Mirror types in `ai-event-client/src/index.ts` (the locally redeclared `ContentPartUrlSource`, `ToolCallPart`, `ToolResultPart`, `ToolCall`, `ImageUsage`) — these must structurally match the authoritative declarations in `@tanstack/ai/src/types.ts` to stay cross-package assignable. Kept as `field?: T` (no `| undefined`). ## Notable per-package work - `ai` (71 errors): widened the shared context / middleware / activity option types. One `as ChatMiddleware` boundary cast on the devtools-middleware structural-equivalent type (sibling package, deliberately duplicated to avoid circular dep). Two conditional spreads at AG-UI `RUN_ERROR` / image-output wire boundaries. - `ai-event-client` (21 errors): widened `BaseEventContext` and the per-event subtype redeclarations of optional fields. Mirror types for content parts deliberately not widened (see above). - `ai-devtools` (31 errors): widened the five store interfaces in `store/ai-context.tsx` (`MessagePart`, `Message`, `Chunk`, `Iteration`, `Conversation`); removed two now-unnecessary `as T[keyof T]` casts. - `openai-base`, `ai-openai`, `ai-openrouter`, `ai-grok`, `ai-groq`: conditional-spread the `RUN_ERROR.code` / nested `error.code` and `RUN_FINISHED.usage` wire payloads, plus `signal` and `headers` into vendor `RequestOptions`. - `ai-anthropic`, `ai-gemini`: conditional-spread vendor-SDK request shape fields (`ThinkingConfig`, `WebSearchTool20250305`, etc). `brandProviderTool` tool factories pass `metadata: config` directly — `Tool.metadata` was widened to allow `| undefined` so the property stays present (smoke tests assert `toHaveProperty('metadata')`). - `ai-isolate-{node,quickjs,cloudflare}`: conditional-spread `NormalizedError.stack` / `code` (type owned by `ai-code-mode`, intentionally narrow). Local `ExecuteResponse` widened. - Framework hooks (`ai-react`, `ai-solid`, `ai-vue`, `ai-svelte`, `ai-preact`): conditional-spread every optional pass-through to `ChatClient` / `GenerationClient` / `VideoGenerationClient` constructors and `updateOptions` calls. Block-bodied callback wrappers in `ai-react` so the `?.()` chain doesn't widen the callback's return type to `void | undefined`. - `ai-openrouter`: vitest mock-hoister collision under `useDefineForClassFields: true` (from the prior commit) needed the inline-class mock rewritten as a constructor function — same fix logic as the `chat = {…}` collision noted there. ## Verification - `pnpm test:types`: 32 projects, 0 errors. - `pnpm test:eslint`: 31 projects, 0 errors (warning baselines unchanged). - `pnpm test:lib`: 31 projects, all tests pass. - `pnpm build`: 31 projects. - 9 examples: all `test:types` exit 0 (one example, `ts-react-media`, needed a local `JobState` discriminant widening + conditional spread on a `RequestInit`-style fetch payload). Covers issue #564 (Stage 3 — final flag). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
🚀 Changeset Version Preview22 package(s) bumped directly, 8 bumped as dependents. 🟩 Patch bumps
|
Drop noPropertyAccessFromIndexSignature and exactOptionalPropertyTypes from tsconfig.base.json — both produced ~500 lines of bracket-access / conditional-spread churn without catching real bugs, and EOPT would have propagated style preferences to downstream consumers running the same flag. Two surgical fix-ups restore narrowing the EOPT-removed explicit guards relied on (realtime-client status/mode dispatch; gemini functionResponse optional chain). Re-enable @typescript-eslint/no-non-null-assertion as an error and refactor all 63 sites across 29 files to avoid `!`: - Map get-then-has → bind result to local, init if missing - array[i] in known-bounded loops → for-of / .entries() / optional chain - arr.shift()! in while → assignment-in-condition pattern - closure-captured non-null → capture into const outside the closure (TS can't propagate narrowing through arrow boundaries) - vendor SDK "known present" fields → narrowing type predicates on .filter, destructure-with-undefined-check, or guarded if-continues Upgrade @typescript-eslint/prefer-readonly from warn to error and fix the 18 sites it surfaced. Keep @typescript-eslint/no-explicit-any as a warning per maintainer preference — existing ~165 warnings unchanged; new introductions surface in editors without blocking CI. Reduce eslint-disable count from 25 to 23; every remaining disable now carries an inline reason. File-level disable in schema-converter .ts replaced with two targeted line-level disables. Dead \`part.type === 'document'\` branch removed from ai-context.tsx. \`while (true)\` in SSE/connection adapters rewritten as \`while (!abortSignal?.aborted)\`. The require-await warning on the sync in-memory SkillStorage implementation refactored to \`Promise.resolve()\` wrappers (no async, no disable). Update changeset to reflect the final rule set. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Switch AudioProviderOptions from a nominal `AudioAdapter<any, any>` match
to a structural `{ '~types': { providerOptions: infer P extends object } }`
extraction. The previous conditional silently collapsed to `object` for
concrete provider options interfaces without an index signature (the
common case), leaving `modelOptions` effectively untyped at activity call
sites. The new form carries the real per-model provider options through,
restores model-specific typing on `modelOptions`, and removes the last
`any` from the audio extraction helper.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
AlemTuzlak
deleted the
564-tighten-typescript-safety-strict-flags-typed-linting-public-api-type-tests
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Closes #564. End-to-end tightening of the TypeScript surface across the monorepo. Each commit on the branch is a self-contained step; reviewing in commit order is easiest.
Commits
test(types): add public-API type-test coverage for chat() and InferChatMessages(a9c2c6f4)chat-per-model-type-safety+ related tests so the public chat/inference surface has type-level coverage before we start tightening underneath it.chore(types): enable strict TS flags(121de4e1)noImplicitOverride,noPropertyAccessFromIndexSignature, andnoFallthroughCasesInSwitchin the roottsconfig.json.openai-base,preact/react/solid-ai-devtools, andai/src.feat(lint): add typed ESLint rules for streaming/agent-loop correctness(0abc52c9)eslint.config.jsscoped topackages/typescript/*/src/**/*.{ts,tsx}:no-floating-promises,no-misused-promises,await-thenable,switch-exhaustiveness-check,consistent-type-exports, plusno-explicit-any/no-non-null-assertion/prefer-readonlyas warnings.@ts-ignore/@ts-expect-errorpolicy: forbids@ts-ignore, requires descriptions on@ts-expect-error(which self-heals once the underlying error disappears).ci: fail CI on @ts-ignore / @ts-nocheck in library source(0714eea6)scripts/check-ts-suppressions.mjsand wires it into the test pipeline as a backstop in case lint is skipped.chore: add changeset for TypeScript safety tightening(95a0fa17)refactor(types): add brandProviderTool helper and use vendor types directly in Anthropic adapter(68cb3851)brandProviderTool<T>()helper in@tanstack/aicollapses 16 phantom-brandas unknown as <ProviderTool>casts across Anthropic, Gemini, and OpenRouter tool factories into one audited site. Usesas T(notas unknown as T) so TS's structural overlap check still applies.ContentBlockParam,ThinkingBlockParam,ToolUseBlockParamdirectly from@anthropic-ai/sdk/resources/messagesand pushes block construction into a typed builder. Eliminates theas unknown as AnthropicContentBlockcast that was masking a TS narrowing limitation, not a real type mismatch.refactor(types): ban as unknown as double-casts in library source(3456bc70)as unknown ascasts to 0 ungated + 12 audited + gated.as T(cast preserved, overlap check restored).stringintoRecord<string, unknown>; Ollama had an unreachable defensive branch castingnevertoRecord<string, unknown>. Both replaced with{}.// eslint-disable-next-line no-restricted-syntax -- <reason>afteras Tfailed the overlap check. Reasons cluster around: conditional return types in framework hooks (4×useChat/createChat), DOM/TS-lib limitations (String.fromCharCode.apply(Uint8Array),Uint8Array.fromBase64Stage-3), discriminated-union construction (OpenRouterNormalizedStreamEvent),RTCErrorEventduck-type, ElevenLabs webhook-variant duck-type.no-restricted-syntaxrule with AST selectorTSAsExpression > TSAsExpression[typeAnnotation.type='TSUnknownKeyword']to prevent regression.refactor(lint): close typed-linting coverage gap in 4 packages(720ffd61)ai,ai-client,ai-svelte,ai-fal) shipped a no-op localeslint.config.jsthat re-exported root with empty rules. Flat-config evaluatesfilesglobs relative to the config-file's directory, so the root's typed-linting block silently didn't apply there.case undefined:branches, AG-UIEventTypeswitches where rule's enum-vs-string-literal analysis misfires (addeddefault+ scopedeslint-disablewith reason),export *→export type *, 3×void-prefix for fire-and-forget promises, 1× async-event-handler wrapped invoid (async () => {})()IIFE.ci(examples): add test:types to all examples and fix surfaced type errors(f2827142)ts-react-mediahad atest:typesscript. The other 8 ran"test": "exit 0"and were never typechecked by CI even though every example ships atsconfig.jsonwith strict mode.test:types.ts-vue-chatusesvue-tsc -b,ts-svelte-chatusessvelte-kit sync && svelte-check, the rest usetsc --noEmit.vanilla-chatneeded atsconfig.json(didn't exist).mergeAgentToolsarray vsRecordshape, per-providerchat()generic erasure (split into ternary), tool handlerunknownargs, AG-UI stream-chunk discriminator update, dead-code cleanup, generated-file exclusions.ci: drop check-ts-suppressions.mjs (redundant with ban-ts-comment)(b5247943)ban-ts-comment's strict policy from applying uniformly. Commit 8 closes that gap; the script's coverage is now identical to ESLint's, gated by the same CI step. Two enforcement paths for one rule creates divergence risk — consolidate on ESLint.Net public-surface impact
brandProviderToolfrom@tanstack/ai(helper for provider-tool factories; type-only at the value level).{}instead of silently propagating a string into aRecordslot).Verification
tsc, and unit tests all pass (1828 tests total).test:typesexits 0.✅ Checklist
pnpm run test:pr.🚀 Release Impact
🤖 Generated with Claude Code