fix: file paths missing .js extension for ESM#365
Merged
tannerlinsley merged 1 commit intoTanStack:mainfrom Feb 13, 2026
Merged
fix: file paths missing .js extension for ESM#365tannerlinsley merged 1 commit intoTanStack:mainfrom
tannerlinsley merged 1 commit intoTanStack:mainfrom
Conversation
|
Can we get this released 🙏 |
Member
|
Released |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #364
A couple of imports were added in f4c9e90 without a
.jsfile extension. This does not get flagged bypnpm buildbecause tsconfig isn't on amodulethat enforces ESM.I can see other files in this repo using ESM-style imports, so this PR does that for these new ones, rather than updating tsconfig which could cause wider changes.