Skip to content

ci: merge github workflows#361

Merged
lachlancollins merged 4 commits intomainfrom
wip-test
Mar 17, 2026
Merged

ci: merge github workflows#361
lachlancollins merged 4 commits intomainfrom
wip-test

Conversation

@lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Mar 17, 2026

🎯 Changes

Merges version-preview workflow into pr.yml

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions workflow configurations for pull request processing, including permission adjustments and git history optimization.
    • Removed an obsolete workflow file to streamline CI/CD automation.

@coderabbitai
Copy link

coderabbitai bot commented Mar 17, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: aed2085d-a401-4a55-8394-a1973cdc2907

📥 Commits

Reviewing files that changed from the base of the PR and between 0964693 and 451cdc8.

📒 Files selected for processing (3)
  • .github/comment-on-release/README.md
  • .github/workflows/changeset-preview.yml
  • .github/workflows/pr.yml

📝 Walkthrough

Walkthrough

These changes restructure GitHub Actions workflows by removing the separate changeset-preview workflow, consolidating functionality into the main PR workflow with a new version-preview job, updating permissions to allow pull request comments, and adjusting git fetch behavior.

Changes

Cohort / File(s) Summary
GitHub Actions Workflows
.github/workflows/changeset-preview.yml, .github/workflows/pr.yml
Removed standalone changeset-preview workflow file. Consolidated its functionality into pr.yml by adding new version-preview job, updating top-level permissions to include pull-requests: write, and removing fetch-depth: 0 configuration from preview and provenance job checkout steps.
Documentation
.github/comment-on-release/README.md
Updated GitHub Actions repository reference path case from tanstack/config to TanStack/config.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A workflow hops into one,
No branches split, but tasks are done,
With permission granted, PR's sing,
Shallower clones, efficiency spring! ✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch wip-test
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@changeset-bot
Copy link

changeset-bot bot commented Mar 17, 2026

⚠️ No Changeset found

Latest commit: 451cdc8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud
Copy link

nx-cloud bot commented Mar 17, 2026

View your CI Pipeline Execution ↗ for commit 451cdc8

Command Status Duration Result
nx affected --targets=test:sherif,test:docs,tes... ✅ Succeeded <1s View ↗
nx run-many --target=build ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-17 11:58:37 UTC

@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2026

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 17, 2026

npm i https://pkg.pr.new/@tanstack/eslint-config@361
npm i https://pkg.pr.new/@tanstack/publish-config@361
npm i https://pkg.pr.new/@tanstack/typedoc-config@361
npm i https://pkg.pr.new/@tanstack/vite-config@361

commit: 451cdc8

@lachlancollins lachlancollins deleted the wip-test branch March 17, 2026 11:50
@lachlancollins lachlancollins marked this pull request as ready for review March 17, 2026 11:58
@lachlancollins lachlancollins changed the title WIP: test preview comment ci: merge github workflows Mar 17, 2026
@lachlancollins lachlancollins merged commit 1d33d64 into main Mar 17, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant