Allow additional externals to be included#43
Merged
lachlancollins merged 1 commit intoTanStack:mainfrom Feb 26, 2024
Merged
Conversation
jprosevear
force-pushed
the
feature/add-optional-externals
branch
2 times, most recently
from
e179bea to
c1c56b1
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 589b0f5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Member
|
Err... We have some problems here with our Prettier config. Tagging in the big guns (@lachlancollins) to review
|
crutchcorn
requested review from
crutchcorn and
lachlancollins
and removed request for
crutchcorn
Contributor
Author
|
I can see how the workflow looks now, I'm looking into it. |
jprosevear
force-pushed
the
feature/add-optional-externals
branch
from
c1c56b1 to
2bc3e79
Compare
Contributor
Author
|
Fixed formatting, looking at the build issue |
jprosevear
force-pushed
the
feature/add-optional-externals
branch
from
070525b to
589b0f5
Compare
Contributor
Author
|
@crutchcorn @lachlancollins resolved, pnpm test:pr now passes locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #42