chore: Fix vite-plugin-externalize-deps except field#47
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2aac4dc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
I believe it adds additional dependencies to be externalized that were not coming from peer deps, deps, etc. I had to externalize a virtual module (I have a vite plugin that handles the loading of this module) - my suspicion is router may eventually need something like this too in the vite plugi. I chose includeExternals so that the api could later be extended with exceptExternals. I agree the semantics are a bit confusing because it "includes" additional externals and "excepts" externals (like from peer deps) that might otherwise
This does the opposite of what I need, i do need access to 'include'. See my work around in #42 (comment) @lachlancollins let me know how we can proceed (or if this is a behavior you prefer not to support). I'll hang out in discord for a bit. |
I'm so sorry, that was a big oops on my side 🤦 I'll fix this now! |
includemarks something as excludedexceptmarks something as to be bundled (confusing I know)externalIncludetobundledDepswhich is clearer IMO