Skip to content

fix: replace bundledDeps with externalDeps#59

Merged
lachlancollins merged 2 commits intomainfrom
fix-external-deps
Mar 2, 2024
Merged

fix: replace bundledDeps with externalDeps#59
lachlancollins merged 2 commits intomainfrom
fix-external-deps

Conversation

@lachlancollins
Copy link
Copy Markdown
Member

@lachlancollins lachlancollins commented Mar 2, 2024

Re-fixes #42 after my confusion around option naming 🤦

New description:

/** Additional dependencies to externalize if not detected by `vite-plugin-externalize-deps` */
externalDeps?: Array<string | RegExp>

Note bundledDeps did not work (included node_modules in output), so it has been removed

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Mar 2, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c45a5fc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@lachlancollins lachlancollins merged commit 72dc4c1 into main Mar 2, 2024
@lachlancollins lachlancollins deleted the fix-external-deps branch March 2, 2024 22:04
@jprosevear
Copy link
Copy Markdown
Contributor

@lachlancollins thanks - works well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to add external dependencies for package

2 participants