Skip to content

Fix issues in Solid.js template (signal accessor not called, React-st… #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2025
Merged

Fix issues in Solid.js template (signal accessor not called, React-st… #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e0a3e8
Fix issues in Solid.js template (signal accessor not called, React-st…
RyotaUshio Oct 11, 2025
427ace0
fix: solid For fix
jherr Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frameworks/solid/add-ons/start/assets/src/routes/demo.start.server-funcs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ function Home() {
}}
class="bg-blue-500 hover:bg-blue-700 text-white font-bold py-2 px-4 rounded"
>
Add 1 to {state}?
Add 1 to {state()}?
</button>
</div>
)
Expand Down
10 changes: 6 additions & 4 deletions frameworks/solid/add-ons/start/assets/src/routes/index.tsx.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { createFileRoute } from "@tanstack/solid-router";
import { For } from "solid-js"
<% if (!tailwind) { %>
import logo from "../logo.svg";
import "../App.css";
Expand Down Expand Up @@ -97,16 +98,17 @@ return (

<section class="py-16 px-6 max-w-7xl mx-auto">
<div class="grid grid-cols-1 md:grid-cols-2 lg:grid-cols-3 gap-6">
{features.map((feature, index) => (
<div
key="{index}"
<For each={features}>
{(feature) => (
<div
class="bg-slate-800/50 backdrop-blur-sm border border-slate-700 rounded-xl p-6 hover:border-cyan-500/50 transition-all duration-300 hover:shadow-lg hover:shadow-cyan-500/10"
>
<div class="mb-4">{feature.icon}</div>
<h3 class="text-xl font-semibold text-white mb-3">{feature.title}</h3>
<p class="text-gray-400 leading-relaxed">{feature.description}</p>
</div>
))}
)}
</For>
</div>
</section>
</div>
Expand Down
Loading