rxdb-db-collection fixes #667
Conversation
Replaces generic 'any' types with more specific types such as 'Subscription' and 'Record<string, unknown>' for improved type safety. Removes unnecessary type assertions and updates function signatures and variable declarations accordingly.
Added '_deleted': false to query selectors to ensure only non-deleted documents are included during synchronization. This improves data consistency by excluding soft-deleted records from sync operations.
🦋 Changeset detectedLatest commit: ee9eca8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Updated the stripRxdbFields function to use a stricter type for the input parameter and removed unnecessary handling for arrays and nullish values.
There was a problem hiding this comment.
Thanks for this @daveycodez
Would it be possible to add a test that validates the delete behaviour?
Seems like a complex test that would need to run in the web browser and then refresh the page to verify. It requires access to localStorage. The issue was that it loads the data and skips rxdb query and runs directly on the storage instance which skips rxdb filtering out deleted documents. |
Added 'rxjs' with version >=7.8.2 to peerDependencies in package.json to ensure compatibility and proper dependency management.
More templates
@tanstack/angular-db
@tanstack/db
@tanstack/db-ivm
@tanstack/electric-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/rxdb-db-collection
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit: |
There was a problem hiding this comment.
Thanks @daveycodez for this. I've added a changeset and will merge. Will be in the next release.
|
🎉 This PR has been released! Thank you for your contribution! |
2 participants
This PR addresses the majority of "any" type usage in the rxdb-db-collection adapter as well as fixes for only querying documents where _deleted is false, which fixes issues when using localStorage or other persistent storage mechanisms.
Fixes #630