-
Notifications
You must be signed in to change notification settings - Fork 138
ci: sync changes from other projects #978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
More templates
@tanstack/angular-db
@tanstack/db
@tanstack/db-ivm
@tanstack/electric-db-collection
@tanstack/offline-transactions
@tanstack/powersync-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/rxdb-db-collection
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit: |
|
Size Change: 0 B Total Size: 88.2 kB ℹ️ View Unchanged
|
|
Size Change: 0 B Total Size: 3.35 kB ℹ️ View Unchanged
|
| "eslint --fix" | ||
| ] | ||
| }, | ||
| "workspaces": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happened here @lachlancollins ? Our workspaces and overrides are gone...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only workspace config needed is in pnpm-workspace.yaml. pnpm also handles all overrides for local packages via linkWorkspacePackages: true and preferWorkspacePackages: true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the explicit overrides because the examples weren't loading the workspace versions — we need package versions there so they're installable outside of the repo but inside the repo, they resolve the workspace version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm that shouldn't be an issue, the examples should still load workspace versions if configured correctly - let me check!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it some more and apparently the behavior is the workspace version is pulled in when it matches. There's perhaps other cases where it wasn't getting pulled into which I ran into before but in any case, yeah I think we're fine.
🎯 Changes
✅ Checklist
pnpm test:pr.🚀 Release Impact