feat: simplify EventClient types to accept unprefixed event maps#361
Merged
AlemTuzlak merged 3 commits intomainfrom Mar 4, 2026
Merged
feat: simplify EventClient types to accept unprefixed event maps#361AlemTuzlak merged 3 commits intomainfrom
AlemTuzlak merged 3 commits intomainfrom
Conversation
EventClient now accepts event maps with plain event names instead of requiring the pluginId prefix in every key. The prefix is handled purely at runtime. This removes the complex conditional types that were stripping prefixes from emit/on/createEventPayload signatures.
🦋 Changeset detectedLatest commit: eb3594f The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit eb3594f
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/devtools
@tanstack/devtools-client
@tanstack/devtools-ui
@tanstack/devtools-utils
@tanstack/devtools-vite
@tanstack/devtools-event-bus
@tanstack/devtools-event-client
@tanstack/preact-devtools
@tanstack/react-devtools
@tanstack/solid-devtools
@tanstack/vue-devtools
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EventClient<TEventMap>now accepts event maps with plain event names (e.g.'ready','mounted') instead of requiring the pluginId prefix in every key (e.g.'tanstack-devtools-core:ready')emit/on/createEventPayloadsignatures — they now use simplekeyof TEventMap & stringTPluginIdtype parameter fromEventCliententirely — the prefix is handled purely at runtimepluginIdrequired onTanStackDevtoolsEventTest plan
npm run test)@tanstack/devtools-event-clientand@tanstack/devtools-clientbuild successfully