fix: type for use with decode-formdata#2052
Merged
crutchcorn merged 1 commit intoTanStack:mainfrom Mar 4, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 4fdb7cc The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
crutchcorn
approved these changes
Mar 4, 2026
|
View your CI Pipeline Execution ↗ for commit 4fdb7cc
☁️ Nx Cloud last updated this comment at |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2052 +/- ##
==========================================
- Coverage 90.35% 0.00% -90.36%
==========================================
Files 38 11 -27
Lines 1752 99 -1653
Branches 444 29 -415
==========================================
- Hits 1583 0 -1583
+ Misses 149 85 -64
+ Partials 20 14 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
The use of
Parameters<typeof decode>here doesn't work right becausedecodehas multiple definitions. This replaces that with a direct reference to the intendedFormDataInfotype, with the ternaries as a workaround fordecode-formdatahaving slightly wonky typing fordecode.✅ Checklist
pnpm test:pr.🚀 Release Impact