Skip to content

NumpadAdd does not match plus-key hotkeys #127

@dinoilic

Description

@dinoilic

TanStack Hotkeys version

v0.10.0

Framework/Library version

v19.2.5

Describe the bug and the steps to reproduce it

When registering a plus-key hotkey, the shortcut works for the main keyboard plus/equals key path, but does not reliably match the numpad plus key (KeyboardEvent.code === "NumpadAdd").

This makes it difficult to support common app shortcuts such as zoom in with Mod + +, where users may reasonably press either the main + key or the numpad + key.

Steps to reproduce:

  1. Register a React hotkey for a plus shortcut, for example { key: "+", mod: true}.
  2. Focus the page.
  3. Press Ctrl + NumpadAdd on Windows/Linux, or Meta + NumpadAdd on macOS.
  4. Observe that the hotkey callback is not invoked.
  5. Add a native keydown listener and inspect the event; the browser emits event.code === "NumpadAdd" and event.key === "+".

Expected behavior:
A plus-key hotkey should match numpad plus as well, or the docs should describe the recommended way to register numpad plus separately.

Actual behavior:
The app needs a separate raw keydown escape hatch for NumpadAdd.

Your Minimal, Reproducible Example - (Sandbox Highly Recommended)

https://codesandbox.io/p/sandbox/condescending-wing-tx6zm7

Screenshots or Videos (Optional)

N/A

Do you intend to try to help solve this bug with your own PR?

None

Terms & Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions