Update tree-generator v3.0: Electric SQL feedback#6
Merged
Conversation
Incorporates feedback from TanStack DB testing (discussions #2 and #3): domain-discovery: - Cross-domain failure modes with `domains` list for semi-lattice coverage - Tensions section for design conflicts between domains - AI-agent-specific failure mode interview questions (Phase 3c) - Composition discovery from package.json peer deps (Phase 2h) - Subsystem and reference candidate flagging per domain (Phase 2c) - Relaxed interview batching for yes/no confirmations - Failure mode status tracking (active/fixed-but-legacy-risk/removed) - Strengthened GitHub issue scanning for architectural positions tree-generator: - Source repository layout for npm distribution in monorepos - package.json `files` array guidance for shipping skills - Framework-integration domain decomposition per adapter package - Adapter-heavy domain guidance (per-adapter reference files) - Cross-domain failure modes written into all relevant SKILL files - Tension notes with cross-references between involved skills - Failure mode status handling (skip removed, annotate legacy-risk) - Content-based reference file heuristics (not just length overflow) - Dense API surface and schema validation reference file triggers Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Remove phantom package_map.yaml references from tree-generator - Fix Phase 3f → 3e cross-reference in domain-discovery - Fix metadata.sources → sources in validation table - Add failure mode → Common Mistake mapping note - Clarify cross-domain failure mode canonical location (list once, tag with domains) - Add skill_spec.md structural template - Compress plausible/silent/grounded definition in tree-generator - Add quality warning to compressed domain-discovery fallback - Clarify "no concept explanations" means external concepts only - Add composition skill cross-reference to domain-discovery Phase 2h Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add domain-discovery and tree-generator meta-skills (v2.1)
…ring Major changes based on Electric SQL test run feedback (discussion #2): Phase reordering: - Phase 1: Quick scan (~10 min orientation) instead of exhaustive read - Phase 2: High-level maintainer interview to extract task map FIRST - Phase 3: Deep read informed by maintainer's mental model - Phase 4: Detail interview (gap-targeted, AI-agent, composition) - Phase 5: Finalize artifacts Output unit shift: - Domains are now an intermediate conceptual grouping, not the output - Skills are the output: task-focused, each matching a developer moment - Skills emerge from intersection of domains × developer tasks - YAML schema restructured: skills are top-level with domain reference New skill types: - lifecycle skills (quickstart, go-live) suggested when docs support them - composition skills promoted from footnotes to full skills Other improvements: - Monorepo heuristic: identify 2-3 core packages, read deeply - GitHub issues fallback: FAQ.md, TROUBLESHOOTING.md when no web access - tree-generator updated to consume new schema shape Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Rewrite domain-discovery to v3.0: task-focused skills, new phase ordering
…ist body Incorporate Electric SQL test feedback (discussion #3): - Add skill type enumeration table (core, sub-skill, framework, lifecycle, composition, security) - Add flat vs nested structure decision with criteria and both directory layouts - Make router skill optional with guidance on when CLI routing suffices - Formalize alternative body template for checklist/audit skills (security, go-live) - Add validation checks for new constraints Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
list/showwhen the skill set is smallAddresses gaps 1, 2, 4, 6 from Electric SQL test feedback. Gaps 3 (migration workflow) and 5 (source synthesis) were intentionally deferred.
Test plan
🤖 Generated with Claude Code