react-query@5.91.2 tries to call query.isFetched() in QueryObserver

[dmytro-shchurov]

Describe the bug

Exactly this release has some wrong internal reference to an outdated package, as I think, cause it tries to call query.isFetched() when assigns isFetched property in createResult(query, options) method return value. And of course fails with an error "isFetched() is not defined"
Prior version access to query.isFetched property, not method

Your minimal, reproducible example

no needed, check out the code

Steps to reproduce

call simple useQuery() with any options

Expected behavior

As a user I expect no error here in the simplest query

How often does this bug happen?

Every time

Screenshots or Videos

No response

Platform

• OS: Windows 11
• Browser: Chrome
• Version: 146.0.7680.80

Tanstack Query adapter

react-query

TanStack Query version

5.91.2

TypeScript version

No response

Additional context

No response

[TkDodo]

isFetched() is a new method on the query itself. On a query observer result, isFetched is a boolean.

[dmytro-shchurov]

query-core/QueryObserver knows nothing about your new method. Had to strict version in package.json to a working one

[TkDodo]

sorry I don’t understand what you mean. queryObserver calls the method here:

query/packages/query-core/src/queryObserver.ts

Line 579 in 3dc3d11

isFetched: query.isFetched(),

and the method is defined here:

query/packages/query-core/src/query.ts

Lines 286 to 288 in 3dc3d11

	isFetched() {
	return this.state.dataUpdateCount + this.state.errorUpdateCount > 0
	}

both are part of the query-core package, and both were released in the same PR. If you depend on @tanstack/react-query: v5.91.2, you also get a strict dependency to query-core of that same version:

https://npmx.dev/package-code/@tanstack/react-query/v/5.91.2/package.json#L46-L48

[dmytro-shchurov]

Exactly! But Chrome reported "isFetched() is not a function". For the simplest query which reads data from a localStorage in a provided async queryFn (I'm not sure this makes some difference).
Everything was rimrafed before an installation (modules, locks, etc.)
I think it makes sense to prepare a working (not working) example. That was my obligation.

[TkDodo]

our codesandbox examples are working so yes, I’d need to see something that doesn’t work please.

my best guess is you have an old version of @tanstack/query-core installed somehow but the latest of @tanstack/react-query.