Skip to content

fix: handle non-null at then end of var in exhaustive-deps #8385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TkDodo merged 1 commit into from
Dec 2, 2024
Merged

fix: handle non-null at then end of var in exhaustive-deps #8385

TkDodo merged 1 commit into from
Dec 2, 2024

Conversation

@imranbarbhuiya
Copy link
Contributor

@imranbarbhuiya imranbarbhuiya commented Dec 2, 2024

followup of #8365

This pr also allows adding ! at the end of var name

@nx-cloud
Copy link

nx-cloud bot commented Dec 2, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0d7e8fd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 2, 2024

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8385

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8385

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8385

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8385

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8385

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8385

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8385

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8385

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8385

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8385

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8385

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8385

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8385

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8385

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8385

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8385

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8385

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8385

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8385

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8385

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8385

commit: 0d7e8fd

@codecov
Copy link

codecov bot commented Dec 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.22%. Comparing base (12b6782) to head (0d7e8fd).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8385       +/-   ##
===========================================
+ Coverage   46.12%   88.22%   +42.10%     
===========================================
  Files         200       15      -185     
  Lines        7504      501     -7003     
  Branches     1712      186     -1526     
===========================================
- Hits         3461      442     -3019     
+ Misses       3668       45     -3623     
+ Partials      375       14      -361
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query 88.22% <ø> (ø)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@TkDodo TkDodo merged commit d9d2728 into TanStack:main Dec 2, 2024
8 checks passed
@imranbarbhuiya imranbarbhuiya deleted the fix/no-null branch December 2, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TkDodo TkDodo TkDodo approved these changes

Assignees

No one assigned

Labels

package: eslint-plugin-query

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@imranbarbhuiya @TkDodo