@tanstack/eslint-plugin-query@4 incompatible with ESLint v9

[funktr0n]

Describe the bug

When trying to install @tanstack/eslint-plugin-query@4 from npm in a project that uses ESLint v9, I'm unable to install without --force or --legacy-peer-deps due to a dependency mismatch.

Additionally, if I try to install the plugin (via one of the flags above) and use it, I get TypeError: t.getAncestors is not a function or its return value is not iterable from ESLint.

Our team has just upgraded to React 18 and are now looking to upgrade React Query to v5 as well, so this plugin would be really helpful to move that initiative along

Your minimal, reproducible example

N/A

Steps to reproduce

1. Create a project with ESLint v9
2. run npm install -D @tanstack/eslint-plugin-query@4

Expected behavior

I expected the plugin to install without issue and to be used by ESLint v9

How often does this bug happen?

Every time

Screenshots or Videos

No response

Platform

• OS: Windows
• NPM: 10.8.2

Tanstack Query adapter

None

TanStack Query version

v4.0.10

TypeScript version

No response

Additional context

No response

[baeharam]

@funktr0n

Tha last "4" version of @tanstack/eslint-plugin-query is 4.38.0 and this package is incompatible with ESLint v9.

package.json of above package

"peerDependencies": {
  "eslint": "^6.0.0 || ^7.0.0 || ^8.0.0"
}

If you wanna use ESLint v9 with this package, you have to upgrade @tanstack/react-query to v5.
v5 is compatible with ESLint v9 and latest version of @tanstack/eslint-plugin-query.

[TkDodo]

Yeah we're not going to add new features to the v4 line.

[funktr0n]

@TkDodo I can definitely understand not wanting to continue to support an older line, so if that's your stance, fair enough.

That said though, the documentation for one of the rules from this plugin reads:

When Not To Use It
If you don't plan to upgrade to TanStack Query v5, then you will not need this rule.

So, it does seem that one of the purposes of this plugin is to help folks upgrade to your v5 line, which is what my team would like to use it for. From that perspective, I guess it would just be nice to be able to use ESLint v9, which came out only 6 months after @tanstack/query v5 was published.

[TkDodo]

yeah I get that. if you know how to fix it, I’d accept a PR, but I won’t actively look into it.

[ashuvssut]

Thanks! bumping the "@tanstack/eslint-plugin-query" to "^5" worked with my eslint v9

[SimenB]

You can use fixupPluginRules

https://eslint.org/blog/2024/05/eslint-compatibility-utilities/

{
  plugins: { '@tanstack/query': fixupPluginRules(eslintPluginTanstackQuery) },
  rules: eslintPluginTanstackQuery.configs.recommended.rules,
}