Skip to content

fix(query-codemods): fix duplicate 'a' typo in placeholder data error#10116

Merged
TkDodo merged 1 commit intoTanStack:mainfrom
ramong26:fix/placeholder-data-property-typo
Feb 11, 2026
Merged

fix(query-codemods): fix duplicate 'a' typo in placeholder data error#10116
TkDodo merged 1 commit intoTanStack:mainfrom
ramong26:fix/placeholder-data-property-typo

Conversation

@ramong26
Copy link
Contributor

@ramong26 ramong26 commented Feb 11, 2026

Fix duplicated article in placeholderData error message

🎯 Changes

Fixed a duplicated article ("a") typo in the error message in already-has-placeholder-data-property.cjs.

Before:

already contains a a "placeholderData" property.

After:

already contains a "placeholderData" property.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).
    d "a" in the

Note: pnpm run test:pr fails due to a knip error about multiple versions of vue-template-compiler in the workspace, which appears unrelated to this change.

Summary by CodeRabbit

Bug Fixes

  • Fixed a typo in an error message to improve clarity when validating placeholder data properties.

@changeset-bot
Copy link

changeset-bot bot commented Feb 11, 2026

⚠️ No Changeset found

Latest commit: 3b87d61

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud
Copy link

nx-cloud bot commented Feb 11, 2026

View your CI Pipeline Execution ↗ for commit 3b87d61

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 11s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-02-11 08:58:16 UTC

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 11, 2026

📝 Walkthrough

Walkthrough

Fixed a typo in an error message string within the AlreadyHasPlaceholderDataProperty utility, removing a duplicate article from the displayed message text.

Changes

Cohort / File(s) Summary
Typo Fix in Error Message
packages/query-codemods/src/v5/keep-previous-data/utils/already-has-placeholder-data-property.cjs
Removed duplicate "a" from error message string; changed "a a 'placeholderData' property" to "a 'placeholderData' property".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

documentation

Poem

A typo lurks within the text so plain,
"a a" becomes just "a" once again—
The rabbit hops through code with care,
Smoothing errors here and there! 🐰✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing a duplicate 'a' typo in a placeholder data error message.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description follows the template structure with all required sections: Changes, Checklist, and Release Impact. Content is clear and specific about the typo fix.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 11, 2026

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10116

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10116

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10116

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10116

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10116

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10116

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10116

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10116

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10116

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10116

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10116

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10116

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10116

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10116

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10116

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10116

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10116

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10116

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10116

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10116

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10116

commit: 3b87d61

@TkDodo TkDodo merged commit e23fa5d into TanStack:main Feb 11, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments