Skip to content

test(react-query/useSuspenseQueries): remove unnecessary 'act' wrapper from background refetch assertions #10350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sukvvon merged 1 commit into from
Mar 29, 2026
+4 −4
Merged

test(react-query/useSuspenseQueries): remove unnecessary 'act' wrapper from background refetch assertions #10350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/react-query/src/__tests__/useSuspenseQueries.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1040,7 +1040,7 @@ describe('useSuspenseQueries 2', () => {
expect(queryFn1).toHaveBeenCalledTimes(0)

// key2 background refetch completes
await act(() => vi.advanceTimersByTimeAsync(11))
await vi.advanceTimersByTimeAsync(11)

expect(rendered.getByText('data1: cached1')).toBeInTheDocument()
expect(rendered.getByText('data2: data2')).toBeInTheDocument()
Expand All @@ -1049,7 +1049,7 @@ describe('useSuspenseQueries 2', () => {
expect(queryFn1).toHaveBeenCalledTimes(0)

// after key2 refetch completes, key1 is still fresh with no refetch triggered
await act(() => vi.advanceTimersByTimeAsync(10))
await vi.advanceTimersByTimeAsync(10)

expect(rendered.getByText('data1: cached1')).toBeInTheDocument()
expect(rendered.getByText('data2: data2')).toBeInTheDocument()
Expand Down Expand Up @@ -1108,7 +1108,7 @@ describe('useSuspenseQueries 2', () => {
expect(queryFn2).toHaveBeenCalledTimes(0)

// key1 background refetch completes
await act(() => vi.advanceTimersByTimeAsync(11))
await vi.advanceTimersByTimeAsync(11)

expect(rendered.getByText('data1: data1')).toBeInTheDocument()
expect(rendered.getByText('data2: cached2')).toBeInTheDocument()
Expand All @@ -1117,7 +1117,7 @@ describe('useSuspenseQueries 2', () => {
expect(queryFn2).toHaveBeenCalledTimes(0)

// after key1 refetch completes, key2 is still fresh with no refetch triggered
await act(() => vi.advanceTimersByTimeAsync(10))
await vi.advanceTimersByTimeAsync(10)

expect(rendered.getByText('data1: data1')).toBeInTheDocument()
expect(rendered.getByText('data2: cached2')).toBeInTheDocument()
Expand Down
Loading