test(vue-query/infiniteQueryOptions): replace query-core 'QueryClient' import with vue-query proxy by DogPawHat · Pull Request #10385 · TanStack/query

DogPawHat · 2026-04-04T20:48:20Z

infiniteQueryOptions.test-d.ts for Vue Query was incorrectly using the bare query client from core instead of the vue proxy query client.

🎯 Changes

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Chores
- Updated internal test imports to use local module sources rather than external dependencies.

infiniteQueryOptions.test-d.ts for Vue Query was incorrectly using the bare query client from core instead of the vue proxy query client.

coderabbitai · 2026-04-04T20:48:36Z

📝 Walkthrough

Walkthrough

Updated imports in a type definition test file by switching the QueryClient import source from the upstream @tanstack/query-core package to a local ../queryClient module wrapper, maintaining existing test logic and type assertions.

Changes

Cohort / File(s)	Summary
Import Source Update `packages/vue-query/src/__tests__/infiniteQueryOptions.test-d.ts`	Redirected `QueryClient` import from upstream package to local wrapper module; test logic remains unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A hop and a skip, imports take flight,
From upstream to home, the path now feels right,
QueryClient wrapped snug, in local embrace,
Tests stand as before—in their rightful place. ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description follows the template structure with a clear explanation of the issue, completed checklist items, and proper release impact assessment.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title accurately describes the main change: updating an import to use Vue Query's proxy QueryClient instead of the core QueryClient in the infiniteQueryOptions test file.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-04-04T20:48:50Z

View your CI Pipeline Execution ↗ for commit 96d5d72

Command	Status	Duration	Result
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1s	View ↗
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	14s	View ↗

☁️ Nx Cloud last updated this comment at 2026-04-05 12:34:49 UTC

pkg-pr-new · 2026-04-04T20:50:18Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10385

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10385

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10385

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10385

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10385

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10385

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10385

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10385

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10385

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10385

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10385

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10385

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10385

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10385

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10385

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10385

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10385

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10385

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10385

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10385

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10385

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10385

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10385

commit: 96d5d72

tests: use proxy instead of query core

a9ed971

infiniteQueryOptions.test-d.ts for Vue Query was incorrectly using the bare query client from core instead of the vue proxy query client.

github-actions bot added the package: vue-query label Apr 4, 2026

Merge branch 'main' into use-vue-proxy-ininite-options

96d5d72

sukvvon changed the title ~~tests: use proxy instead of query core~~ test(vue-query/infiniteQueryOptions): replace query-core 'QueryClient' import with vue-query proxy Apr 5, 2026

sukvvon approved these changes Apr 5, 2026

View reviewed changes

sukvvon merged commit fcaa1d2 into TanStack:main Apr 5, 2026
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(vue-query/infiniteQueryOptions): replace query-core 'QueryClient' import with vue-query proxy#10385

test(vue-query/infiniteQueryOptions): replace query-core 'QueryClient' import with vue-query proxy#10385
sukvvon merged 2 commits intoTanStack:mainfrom
DogPawHat:use-vue-proxy-ininite-options

DogPawHat commented Apr 4, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Apr 4, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

nx-cloud bot commented Apr 4, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Apr 4, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

DogPawHat commented Apr 4, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

nx-cloud bot commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

DogPawHat commented Apr 4, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 4, 2026 •

edited

Loading

nx-cloud bot commented Apr 4, 2026 •

edited

Loading

pkg-pr-new bot commented Apr 4, 2026 •

edited

Loading